Review main Merged

60805[TASK] Deprecate `top.rawurlencode` and `top.str_replace`

Andreas Kienast CR +2 V +2 Normal +66 −29 updated 05/24/19, 11:04

Commit message

The global JavaScript functions `top.rawurlencode()` and
`top.str_replace()` were introduced in 2009 and have been marked as
deprecated now. The code is not required and some special handling used
in these functions may get achieved with native JavaScript functions.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1014

  1. Andreas Kienast uploaded patch set 1 05/24/19, 09:29

  2. TYPO3com voted on patch set 1 V +1 05/24/19, 09:42 Completed build in 12m 34s on Fri, 24 May, 11:42 AM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33993

  3. Oliver Klee voted on patch set 1 CR +1 05/24/19, 09:49

  4. Andreas Kienast uploaded patch set 2 05/24/19, 10:04

  5. Susi Moog voted on patch set 2 CR +1 05/24/19, 10:08

  6. Andreas Kienast uploaded patch set 3 05/24/19, 10:11

  7. Andreas Kienast uploaded patch set 4 05/24/19, 10:12

  8. TYPO3com voted on patch set 2 V +1 05/24/19, 10:32 Completed build in 23m 34s on Fri, 24 May, 12:32 PM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33999

  9. TYPO3com voted on patch set 4 V -1 05/24/19, 10:36 Completed build in 17m 51s on Fri, 24 May, 12:36 PM Test Summary: 9 of 46788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34001

  10. TYPO3com voted on patch set 4 V +1 05/24/19, 10:42 Completed build in 41m 33s on Fri, 24 May, 12:42 PM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34001

  11. Susi Moog voted on patch set 4 V +1 CR +1 05/24/19, 10:42

  12. Oliver Klee voted on patch set 4 CR +1 05/24/19, 11:03

  13. Frank Nägler voted on patch set 4 V +2 CR +2 05/24/19, 11:04

  14. Frank Nägler merged patch set 5 05/24/19, 11:04