Review main Merged

60806[BUGFIX] Require `jquery` before using it when rendering ckeditor

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 05/24/19, 10:52

Commit message

In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interesting is that jquery
is explicitly required two lines later.

The code is now changed to require jquery before using its document.ready()
handling.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Andreas Kienast uploaded patch set 1 05/24/19, 09:55

  2. Mathias Brodala updated the commit message in patch set 2 05/24/19, 10:00

  3. Mathias Brodala voted on patch set 2 CR +1 05/24/19, 10:00

  4. TYPO3com voted on patch set 1 V +1 05/24/19, 10:13 Completed build in 17m 22s on Fri, 24 May, 12:13 PM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33995

  5. TYPO3com voted on patch set 2 V +1 05/24/19, 10:18 Completed build in 15m 02s on Fri, 24 May, 12:18 PM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33997

  6. Andreas Kienast updated the commit message in patch set 3 05/24/19, 10:19

  7. Frank Nägler voted on patch set 3 V +1 CR +1 05/24/19, 10:27

  8. TYPO3com voted on patch set 3 V -1 05/24/19, 10:42 Completed build in 18m 41s on Fri, 24 May, 12:42 PM Test Summary: 9 of 46788 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34002

  9. TYPO3com voted on patch set 3 V +1 05/24/19, 10:50 Completed build in 46m 05s on Fri, 24 May, 12:50 PM Test Summary: 46449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34002

  10. Susi Moog voted on patch set 3 V +2 CR +2 05/24/19, 10:52

  11. Susi Moog merged patch set 4 05/24/19, 10:52