Review TYPO3_8-7 Merged

60808[BUGFIX] Require `jquery` before using it when rendering ckeditor

Susi Moog CR +2 V +2 Easy +3 −3 updated 05/24/19, 12:14

Commit message

In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interesting is that jquery
is explicitly required two lines later.

The code is now changed to require jquery before using its document.ready()
handling.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Susi Moog commented on patch set 1 05/24/19, 10:53

    Cherry Picked from branch 9.5.
  2. Oliver Klee voted on patch set 1 CR +1 05/24/19, 11:05

  3. TYPO3com voted on patch set 1 V +1 05/24/19, 11:19 Completed build in 25m 59s on Fri, 24 May, 01:19 PM Test Summary: 80302 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3534

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 05/24/19, 12:14

  5. Andreas Kienast merged patch set 2 05/24/19, 12:14