Review main Merged

60810[TASK] Deprecate top.openUrlInWindow

Andreas Kienast CR +2 V +2 Easy +36 −2 updated 05/24/19, 12:50

Commit message

The global JavaScript function `top.openUrlInWindow()` has been marked as
deprecated. This method was used to open links in a full size popup.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Andreas Kienast uploaded patch set 1 05/24/19, 12:04

  2. Frank Nägler voted on patch set 1 V +1 CR +1 05/24/19, 12:09

  3. TYPO3com voted on patch set 1 V +1 05/24/19, 12:18 Completed build in 13m 59s on Fri, 24 May, 02:18 PM Test Summary: 46457 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34012

  4. Oliver Klee commented on patch set 1 05/24/19, 12:23

    backend.js:75

    Maybe also a message saying in which version it will be removed?
  5. Andreas Kienast commented on patch set 1 05/24/19, 12:50

    backend.js:75 Reply

    Usually this isn't annotated anywhere anymore, since it's commonly known we remove deprecations in the following major (11 in this case) version.
  6. Susi Moog commented on patch set 1 V +2 CR +2 05/24/19, 12:50

    The deprecation message fits with what we are currently using in other places as well. _IF_ we decide to want the version included, I'd say let's adjust all of them in a single patch.
  7. Susi Moog merged patch set 2 05/24/19, 12:50