60818[TASK] Open ElementBrowser event based in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Container/InlineControlContainer.ts+0 −20
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/ElementBrowser.php+3 −6
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php4+2 −10
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+9 −0
Review log 911
-
Andreas Kienast uploaded patch set 1 05/24/19, 14:45
-
Andreas Kienast uploaded patch set 2 05/24/19, 14:52
-
TYPO3com voted on patch set 2 V +1 05/24/19, 15:05 Completed build in 12m 46s on Fri, 24 May, 05:05 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34029
-
Tymoteusz Motylewski commented on patch set 2 05/27/19, 21:10
TableList.php:60is htmlspecialchar without additional flag enough? htmlspecialchars($itemName . '|||' . $tableName, ENT_QUOTES | ENT_HTML5) -
Tymoteusz Motylewski commented on patch set 2 05/28/19, 21:26
Hi Can you please specify which 3 places are there to test? This would ease testing. -
Andreas Kienast commented on patch set 2 05/29/19, 06:08
> Can you please specify which 3 places are there to test? This would ease testing. Sure: 1. FAL (e.g. "Add image") 2. Any group field with a "table" button (e.g. styleguide > elements group > group_db_1 > "Backend User" or "Backend usergroup" 3. In the same field as in 2.), the "opener" button on the right side (the one with the folder icon)TableList.php:44Reply UnresolvedLooks good, thanks.TableList.php:60Reply UnresolvedI didn't find any case that breaks without it, yet. -
Andreas Kienast commented on patch set 3 06/01/19, 20:05
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 06/01/19, 20:18 Completed build in 13m 29s on Sat, 1 Jun, 10:19 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34129
-
Daniel Goerz voted on patch set 3 V +1 CR +1 06/27/19, 12:33
-
Benni Mack voted on patch set 3 V +2 CR +2 06/27/19, 17:36
-
Benni Mack merged patch set 4 06/27/19, 17:36
TableList.php:44