Review main Merged

60818[TASK] Open ElementBrowser event based in FormEngine

Andreas Kienast CR +2 V +2 Normal +16 −38 updated 06/27/19, 17:36

Commit message

Currently, the ElementBrowser is used in three different places in
FormEngine, all of them trigger it differently. This patch introduces
an event-driven approach and streamlines all usages.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 911

  1. Andreas Kienast uploaded patch set 1 05/24/19, 14:45

  2. Andreas Kienast uploaded patch set 2 05/24/19, 14:52

  3. TYPO3com voted on patch set 2 V +1 05/24/19, 15:05 Completed build in 12m 46s on Fri, 24 May, 05:05 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34029

  4. Tymoteusz Motylewski commented on patch set 2 05/27/19, 21:10

    TableList.php:44

    I think this can be simplified even further: if (empty($config['allowed']) || !is_string($config['allowed']) || !isset($config['internal_type']) || $config['internal_type'] !== 'db') {

    TableList.php:60

    is htmlspecialchar without additional flag enough? htmlspecialchars($itemName . '|||' . $tableName, ENT_QUOTES | ENT_HTML5)
  5. Tymoteusz Motylewski commented on patch set 2 05/28/19, 21:26

    Hi Can you please specify which 3 places are there to test? This would ease testing.
  6. Andreas Kienast commented on patch set 2 05/29/19, 06:08

    > Can you please specify which 3 places are there to test? This would ease testing. Sure: 1. FAL (e.g. "Add image") 2. Any group field with a "table" button (e.g. styleguide > elements group > group_db_1 > "Backend User" or "Backend usergroup" 3. In the same field as in 2.), the "opener" button on the right side (the one with the folder icon)

    TableList.php:44 Reply Unresolved

    Looks good, thanks.

    TableList.php:60 Reply Unresolved

    I didn't find any case that breaks without it, yet.
  7. Andreas Kienast commented on patch set 3 06/01/19, 20:05

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 06/01/19, 20:18 Completed build in 13m 29s on Sat, 1 Jun, 10:19 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34129

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 06/27/19, 12:33

  10. Benni Mack voted on patch set 3 V +2 CR +2 06/27/19, 17:36

  11. Benni Mack merged patch set 4 06/27/19, 17:36