Review main Merged

60821[BUGFIX] Clamp "simulateDate" timestamp to minimum 60 seconds

Christian Eßl CR +2 V +2 Easy +6 −1 updated 05/31/19, 11:25

Commit message

In order to avoid RuntimeExceptions, the "simulateDate" TSConfig setting
for the  adminpanel has to be at least 60 seconds. Otherwise
$GLOBALS['SIM_ACCESS_TIME'] will be set to 0.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Christian Eßl uploaded patch set 1 05/25/19, 05:58

  2. TYPO3com voted on patch set 1 V +1 05/25/19, 06:10 Completed build in 12m 07s on Sat, 25 May, 08:10 AM Test Summary: 46474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34035

  3. Oliver Klee commented on patch set 1 05/25/19, 09:50

    PreviewModule.php:243

    I propose using the "min" function here.
  4. Christian Eßl uploaded patch set 2 05/25/19, 13:13

  5. Christian Eßl commented on patch set 2 05/25/19, 13:14

    PreviewModule.php:243 Reply

    I think you mean "max"?
  6. TYPO3com voted on patch set 2 V +1 05/25/19, 13:25 Completed build in 12m 03s on Sat, 25 May, 03:25 PM Test Summary: 46474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34043

  7. Oliver Klee commented on patch set 2 05/25/19, 14:18

    Right, of course "max".
  8. Oliver Klee voted on patch set 2 CR +1 05/25/19, 14:18

  9. Christian Eßl updated the commit message in patch set 3 05/27/19, 03:52

  10. TYPO3com voted on patch set 3 V +1 05/27/19, 04:14 Completed build in 18m 51s on Mon, 27 May, 06:14 AM Test Summary: 46474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34058

  11. Benni Mack voted on patch set 3 CR +1 05/27/19, 04:36

  12. Frank Nägler voted on patch set 3 V +1 CR +1 05/31/19, 09:25

  13. Oliver Klee voted on patch set 3 CR +1 05/31/19, 10:36

  14. Andreas Kienast voted on patch set 3 V +1 CR +1 05/31/19, 11:24

  15. Frank Nägler voted on patch set 3 V +2 CR +2 05/31/19, 11:24

  16. Frank Nägler merged patch set 4 05/31/19, 11:25