60822[TASK] Add links to the loaded images in the info module
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Andreas Kienast +1
-
Verified V +2 Done
- Frank Nägler +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2127
Show 12 earlier messages
-
Christian Eßl uploaded patch set 1 05/25/19, 08:09
-
TYPO3com voted on patch set 1 V +1 05/25/19, 08:23 Completed build in 14m 24s on Sat, 25 May, 10:23 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34039
-
Guido Schmechel commented on patch set 1 05/25/19, 19:17
Good little improvement. Maybe you can remove the space in the commit message at "Images on this page" Otherwise I was able to test the feature successfully. -
Guido Schmechel commented on patch set 1 05/25/19, 19:17
IMO you can add 9.5 as well to the releases line. -
Oliver Klee commented on patch set 1 05/25/19, 20:09
This looks more like FEATURE to me than a TASK. -
Christian Eßl updated the commit message in patch set 2 05/27/19, 03:52
-
Christian Eßl uploaded patch set 3 05/27/19, 03:57
-
Christian Eßl updated the commit message in patch set 4 05/27/19, 03:58
-
TYPO3com voted on patch set 2 V +1 05/27/19, 04:25 Completed build in 29m 47s on Mon, 27 May, 06:25 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34059
-
TYPO3com voted on patch set 3 V +1 05/27/19, 04:43 Completed build in 27m 33s on Mon, 27 May, 06:43 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34061
-
TYPO3com voted on patch set 4 V +1 05/27/19, 04:50 Completed build in 24m 57s on Mon, 27 May, 06:50 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34062
-
Georg Ringer commented on patch set 4 05/27/19, 05:46
Thanks for your patch! I prefer to change that to a TASK! FEATURES are for master only -
Christian Eßl commented on patch set 4 05/27/19, 05:59
> Patch Set 4: > > Thanks for your patch! I prefer to change that to a TASK! FEATURES are for master only Ok, now we have 1 vote for FEATURE and 1 vote for TASK. But I believe TASK would be fitting as well. -
Guido Schmechel commented on patch set 4 05/27/19, 08:19
IMO its a little improvement but not a feature -
Riccardo De Contardi voted on patch set 4 V +1 05/27/19, 21:41
-
Tobi Kretschmann voted on patch set 4 CR +1 05/28/19, 19:59
-
Tymoteusz Motylewski commented on patch set 4 05/28/19, 20:40
General.html:28will it work for images stored in external storages e.g. S3? -
Christian Eßl commented on patch set 4 05/29/19, 19:55
General.html:28Reply UnresolvedThe {file.name} come from: $processedImage->getPublicUrl() So I think yes. -
Frank Nägler uploaded patch set 5 05/31/19, 07:59
-
Frank Nägler commented on patch set 5 V +1 CR +1 05/31/19, 08:00
I have put the icon in front of the name no streamline the look and feel. I look a bit better now. -
TYPO3com voted on patch set 5 V +1 05/31/19, 08:12 Completed build in 12m 55s on Fri, 31 May, 10:12 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34109
-
Andreas Kienast commented on patch set 5 CR -1 05/31/19, 12:11
taboverrides gets changes and gets its sourcemap again -
Andreas Kienast uploaded patch set 6 05/31/19, 12:16
-
Andreas Kienast voted on patch set 6 V +1 CR +1 05/31/19, 12:16
-
Frank Nägler voted on patch set 6 V +2 CR +2 05/31/19, 12:17
-
TYPO3com voted on patch set 6 V +1 05/31/19, 12:49 Completed build in 17m 12s on Fri, 31 May, 02:49 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34119
-
Frank Nägler merged patch set 7 05/31/19, 12:51