Review main Merged

60823[BUGFIX] Add a unit to the document size in the adminpanel

Christian Eßl CR +2 V +2 Easy +1 −1 updated 05/31/19, 09:02

Commit message

There is a "document size" row in the info module of the
adminpanel. Currently the value is outputted as integer, which strips
out its unit. This patch fixes that.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Christian Eßl uploaded patch set 1 05/25/19, 08:19

  2. TYPO3com voted on patch set 1 V +1 05/25/19, 08:31 Completed build in 12m 27s on Sat, 25 May, 10:31 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34040

  3. Christian Eßl updated the commit message in patch set 2 05/25/19, 09:07

  4. TYPO3com voted on patch set 2 V +1 05/25/19, 09:21 Completed build in 13m 33s on Sat, 25 May, 11:21 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34041

  5. Christian Eßl updated the commit message in patch set 3 05/27/19, 03:51

  6. TYPO3com voted on patch set 3 V +1 05/27/19, 04:12 Completed build in 16m 46s on Mon, 27 May, 06:12 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34057

  7. Benni Mack commented on patch set 3 05/27/19, 04:37

    General.html:52 Unresolved

    do we need the "as string" then at all?
  8. Christian Eßl uploaded patch set 4 05/27/19, 05:55

  9. TYPO3com voted on patch set 4 V +1 05/27/19, 06:04 Completed build in 09m 22s on Mon, 27 May, 08:04 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34065

  10. Riccardo De Contardi commented on patch set 4 V +1 05/27/19, 21:25

    It works, but what unit is "Ki"? Shouldn't it be "Kb" ?
  11. Christian Eßl commented on patch set 4 05/28/19, 05:47

    > Patch Set 4: Verified+1 > > It works, but what unit is "Ki"? Shouldn't it be "Kb" ? It's the same unit already used anywhere else. (for instance, the image list in the adminpanel) and comes from GeneralUtility::formatSize().(iec prefixes with base 1024) Not sure, if it's technically correct, I'm also more familiar "Kb".
  12. Tobi Kretschmann voted on patch set 4 CR +1 05/28/19, 19:55

  13. Frank Nägler voted on patch set 4 V +2 CR +2 05/31/19, 09:02

  14. Frank Nägler merged patch set 5 05/31/19, 09:02