Review main Abandoned

60825[BUGFIX] Make "first subpage" shortcuts redirect to first translated page

Christian Eßl CR 0 V 0 Normal +74 −12 updated 07/05/23, 21:10

Commit message

When a shortcut page is set to "first subpage of selected/current page"
as shortcut mode, it is usually supposed to redirect to the first subpage.

When "hidePagesIfNotTranslatedByDefault" is set in the admin tool, this
will lead to a 404 error, when the first subpage in the page tree has no
translation for the current frontend language. This patch makes sure,
when "hidePagesIfNotTranslatedByDefault" is set, to actually fetch the
first _translated_ page.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 3046

Show 1321 earlier messages
  1. Christian Eßl uploaded patch set 1 05/26/19, 19:02

  2. TYPO3com voted on patch set 1 V -1 05/26/19, 19:02 Completed build in 16s on Sun, 26 May, 09:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34048

  3. Christian Eßl uploaded patch set 2 05/26/19, 19:11

  4. TYPO3com commented on patch set 2 05/26/19, 19:11 Completed build in 12s on Sun, 26 May, 09:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34049

  5. Christian Eßl uploaded patch set 3 05/26/19, 19:18

  6. TYPO3com voted on patch set 3 V +1 05/26/19, 19:29 Completed build in 10m 33s on Sun, 26 May, 09:29 PM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34052

  7. Christian Eßl updated the commit message in patch set 4 05/27/19, 03:54

  8. TYPO3com voted on patch set 4 V -1 05/27/19, 04:25 Completed build in 30m 14s on Mon, 27 May, 06:25 AM Test Summary: 1 of 46815 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34060

  9. Benni Mack commented on patch set 4 05/27/19, 04:36

    PageRepository.php:928

    You should be able to just use "$this->sys_language_uid" for now.

    PageRepository.php:932

    Does $this->isPageSuitableForLanguage($pV, $this->context->getAspect('language')) help?
  10. Christian Eßl commented on patch set 4 05/29/19, 19:26

    Sorry, answered the question already a few days ago but forgot to publish this. (new to gerrit ;) )

    PageRepository.php:932 Reply

    > Does $this->isPageSuitableForLanguage($pV, $this->context->getAspect('language')) help? I thought about that method first but it does other language that are not needed as well and I believe this could lead to unwanted side effects fort shortcuts. (Hard to say, the PageRepository code base is pretty obscure) Maybe we could split the isPageSuitableForLanguage() into several subparts to get the code a bit cleaner.
  11. Christian Eßl uploaded patch set 5 05/29/19, 19:30

  12. TYPO3com voted on patch set 5 V +1 05/29/19, 19:42 Completed build in 11m 32s on Wed, 29 May, 09:42 PM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34091

  13. Christian Eßl uploaded patch set 6 09/23/19, 16:25

  14. TYPO3com voted on patch set 6 V -1 09/23/19, 16:34 Completed build in 08m 40s on Mon, 23 Sep, 04:34 PM Test Summary: 4 of 48105 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36699

  15. Christian Eßl uploaded patch set 7 10/02/19, 17:47

  16. Christian Eßl commented on patch set 7 10/02/19, 17:54

    PageRepository.php:928 Reply

    Done

    PageRepository.php:932 Reply

    Ack
  17. TYPO3com voted on patch set 7 V +1 10/02/19, 17:59 Completed build in 11m 13s on Wed, 2 Oct, 05:59 PM Test Summary: 47765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37018

  18. Sascha Rademacher voted on patch set 7 V +1 CR +1 10/09/19, 09:43

  19. Susi Moog commented on patch set 7 10/26/19, 09:26

    can you update the patch / resolve the conflicts please? Additionally I'd say let's not back port this to 8.7 as it is in only priority bug fixing mode.
  20. Christian Eßl uploaded patch set 8 10/31/19, 08:50

  21. TYPO3com voted on patch set 8 V -1 10/31/19, 09:02 Completed build in 11m 23s on Thu, 31 Oct, 09:02 AM Test Summary: 1 of 48444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37885

  1. Christian Eßl updated the commit message in patch set 9 10/31/19, 09:19

  2. TYPO3com voted on patch set 9 V -1 10/31/19, 09:30 Completed build in 10m 27s on Thu, 31 Oct, 09:30 AM Test Summary: 1 of 48444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37886

  3. Benni Mack commented on patch set 9 CR -1 11/04/19, 16:36

    PageRepository.php:929

    this is only doing "half the job" - e.g. "hideDefaultLanguageOfPages" is not considered. Can you check and apply "PageRepository->isPageSuitableForLanguage()" in this case?
  4. Daniel Goerz uploaded patch set 10 02/27/20, 17:28

  5. TYPO3com voted on patch set 10 V -1 02/27/20, 17:38 Completed build in 10m 02s on Thu, 27 Feb, 05:38 PM Test Summary: 3 of 72487 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-753

  6. Christian Eßl marked it work in progress 03/09/20, 11:54

  7. Benni Mack wrote 11/29/21, 10:01

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 11 11/29/21, 13:16

  9. Benni Mack uploaded patch set 12 12/01/21, 08:38

  10. core-ci voted on patch set 12 V -1 12/01/21, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20291

  11. Benni Mack uploaded patch set 13 01/05/22, 10:32

  12. Benni Mack commented on patch set 13 01/05/22, 10:32

    PageRepository.php:929 Reply

    Done
  13. core-ci voted on patch set 13 V -1 01/05/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21636

  14. Benni Mack uploaded patch set 14 01/05/22, 13:12

  15. core-ci voted on patch set 14 V -1 01/05/22, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21644

  16. Benni Mack uploaded patch set 15 V -1 07/04/23, 19:33

  17. Benni Mack marked it ready for review 07/04/23, 19:34

  18. core-ci voted on patch set 15 V -1 07/04/23, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43423

  19. Benni Mack uploaded patch set 16 V -1 07/04/23, 19:59

  20. core-ci voted on patch set 16 V +1 07/04/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43428

  21. Benni Mack voted on patch set 16 CR +1 07/05/23, 07:15

  22. Susi Moog commented on patch set 16 V -1 07/05/23, 14:13

    This does not work, as the PageRepository at the point in time has no Language settings in Context yet. With https://review.typo3.org/c/Packages/TYPO3.CMS/+/76459 the behaviour works.
  23. Benni Mack rebased onto patch set 17 CR +1 V +1 07/05/23, 20:45

  24. core-ci voted on patch set 17 V +1 07/05/23, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43626

  25. Benni Mack abandoned the change 07/05/23, 21:10