Review main Merged

60827[BUGFIX] Add integer type casting to uids in SeparateSysHistoryFromSysLogUpdate wizard

Christian Eßl CR +2 V +2 Easy +2 −2 updated 05/31/19, 09:11

Commit message

Ensure the uid fields in the SeparateSysHistoryFromSysLogUpdate that are
passed to RecordHistoryStore::addRecord() and
RecordHistoryStore::deleteRecord() are type casted to integers.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Christian Eßl uploaded patch set 1 05/26/19, 19:34

  2. TYPO3com voted on patch set 1 V +1 05/26/19, 19:47 Completed build in 13m 09s on Sun, 26 May, 09:47 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34053

  3. Oliver Klee commented on patch set 1 05/26/19, 21:33

    Is 9.5 affected as well?
  4. Christian Eßl updated the commit message in patch set 2 05/27/19, 03:50

  5. TYPO3com voted on patch set 2 V +1 05/27/19, 04:05 Completed build in 14m 57s on Mon, 27 May, 06:05 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34056

  6. Tymoteusz Motylewski voted on patch set 2 CR +1 05/27/19, 20:47

  7. Oliver Klee voted on patch set 2 CR +1 05/27/19, 23:06

  8. Georg Ringer voted on patch set 2 V +1 CR +1 05/28/19, 12:57

  9. Tobi Kretschmann voted on patch set 2 CR +1 05/28/19, 19:49

  10. Frank Nägler voted on patch set 2 V +2 CR +2 05/31/19, 09:11

  11. Frank Nägler merged patch set 3 05/31/19, 09:11