Review main Merged

60831[BUGFIX] Allow same configuration key in multiple extensions

Jonas Eberle CR +2 V +2 Easy +29 −13 updated 06/12/19, 04:18

Commit message

Fix two issues in the extension configuration tool if more than one
extension is using the same configuration key:

* Remove duplicate HTML IDs in extension configuration tool
* Correctly add hidden fields with value=0 for checkboxes within every
  sub-<form>, not only on first occurence (first extension) of any given
  configuration key

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1924

  1. Jonas Eberle uploaded patch set 1 05/27/19, 19:49

  2. TYPO3com voted on patch set 1 V +1 05/27/19, 20:00 Completed build in 10m 10s on Mon, 27 May, 10:00 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34070

  3. Jonas Eberle uploaded patch set 2 05/27/19, 20:57

  4. Jonas Eberle uploaded patch set 3 05/27/19, 21:10

  5. TYPO3com voted on patch set 2 V +1 05/27/19, 21:13 Completed build in 15m 34s on Mon, 27 May, 11:13 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34072

  6. TYPO3com voted on patch set 3 V +1 05/27/19, 21:23 Completed build in 12m 33s on Mon, 27 May, 11:23 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34073

  7. Tobi Kretschmann commented on patch set 3 CR +1 05/28/19, 20:14

    TypoScriptConstantsViewHelper.php:350

    While I think think this implementation ist ok. I question the necessity of the method "getName()". Maybe it can be removed?
  8. Jonas Eberle commented on patch set 3 05/29/19, 18:08

    I am not sure if I should do this within this patch. I absolutely agree that getName() has a funny code smell, though.
  9. Guido Schmechel commented on patch set 3 05/30/19, 16:33

    TypoScriptConstantsViewHelper.php:350 Reply Unresolved

    getName() is still used elsewhere. Should we use then also here.
  10. Frank Nägler voted on patch set 3 CR +1 05/31/19, 07:07

  11. Frank Nägler voted on patch set 3 V +1 05/31/19, 07:23

  12. Jonas Eberle commented on patch set 3 05/31/19, 08:48

    Ok, so I am going to use it, too.
  13. Frank Nägler commented on patch set 3 CR -1 05/31/19, 10:48

    this patch get an update
  14. Jonas Eberle uploaded patch set 4 05/31/19, 12:51

  15. Jonas Eberle commented on patch set 4 05/31/19, 12:57

    TypoScriptConstantsViewHelper.php:350

    This keeps the access of $configuration['name'] in line with the already existing usages. If we would do a cleanup, I would vote to remove getName() completely.
  16. TYPO3com voted on patch set 4 V +1 05/31/19, 13:13 Completed build in 18m 41s on Fri, 31 May, 03:13 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34121

  17. Frank Nägler commented on patch set 4 V +1 CR +1 05/31/19, 13:48

    Agree, I see no benefit for the method. let remove the method in an own patch.
  18. Markus Klein voted on patch set 4 V +1 CR +1 05/31/19, 13:56

  19. Guido Schmechel voted on patch set 4 V +1 CR +1 06/02/19, 08:56

  20. Jonas Eberle rebased onto patch set 5 06/03/19, 12:19

  21. TYPO3com voted on patch set 5 V +1 06/03/19, 12:32 Completed build in 12m 21s on Mon, 3 Jun, 02:32 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34145

  22. Guido Schmechel voted on patch set 5 V +1 CR +1 06/03/19, 13:05

  23. Benni Mack voted on patch set 5 V +2 CR +2 06/12/19, 04:18

  24. Benni Mack merged patch set 6 06/12/19, 04:18