60831[BUGFIX] Allow same configuration key in multiple extensions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1924
-
Jonas Eberle uploaded patch set 1 05/27/19, 19:49
-
TYPO3com voted on patch set 1 V +1 05/27/19, 20:00 Completed build in 10m 10s on Mon, 27 May, 10:00 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34070
-
Jonas Eberle uploaded patch set 2 05/27/19, 20:57
-
Jonas Eberle uploaded patch set 3 05/27/19, 21:10
-
TYPO3com voted on patch set 2 V +1 05/27/19, 21:13 Completed build in 15m 34s on Mon, 27 May, 11:13 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34072
-
TYPO3com voted on patch set 3 V +1 05/27/19, 21:23 Completed build in 12m 33s on Mon, 27 May, 11:23 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34073
-
Tobi Kretschmann commented on patch set 3 CR +1 05/28/19, 20:14
-
Jonas Eberle commented on patch set 3 05/29/19, 18:08
I am not sure if I should do this within this patch. I absolutely agree that getName() has a funny code smell, though. -
Guido Schmechel commented on patch set 3 05/30/19, 16:33
TypoScriptConstantsViewHelper.php:350Reply UnresolvedgetName() is still used elsewhere. Should we use then also here. -
Frank Nägler voted on patch set 3 CR +1 05/31/19, 07:07
-
Frank Nägler voted on patch set 3 V +1 05/31/19, 07:23
-
Jonas Eberle commented on patch set 3 05/31/19, 08:48
Ok, so I am going to use it, too. -
Frank Nägler commented on patch set 3 CR -1 05/31/19, 10:48
this patch get an update -
Jonas Eberle uploaded patch set 4 05/31/19, 12:51
-
Jonas Eberle commented on patch set 4 05/31/19, 12:57
TypoScriptConstantsViewHelper.php:350This keeps the access of $configuration['name'] in line with the already existing usages. If we would do a cleanup, I would vote to remove getName() completely. -
TYPO3com voted on patch set 4 V +1 05/31/19, 13:13 Completed build in 18m 41s on Fri, 31 May, 03:13 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34121
-
Frank Nägler commented on patch set 4 V +1 CR +1 05/31/19, 13:48
Agree, I see no benefit for the method. let remove the method in an own patch. -
Markus Klein voted on patch set 4 V +1 CR +1 05/31/19, 13:56
-
Guido Schmechel voted on patch set 4 V +1 CR +1 06/02/19, 08:56
-
Jonas Eberle rebased onto patch set 5 06/03/19, 12:19
-
TYPO3com voted on patch set 5 V +1 06/03/19, 12:32 Completed build in 12m 21s on Mon, 3 Jun, 02:32 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34145
-
Guido Schmechel voted on patch set 5 V +1 CR +1 06/03/19, 13:05
-
Benni Mack voted on patch set 5 V +2 CR +2 06/12/19, 04:18
-
Benni Mack merged patch set 6 06/12/19, 04:18
TypoScriptConstantsViewHelper.php:350