Review TYPO3_8-7 Abandoned

60833[BUGFIX] Restore absRefPrefix in AdminPanel of cached pages

Michael Stucki CR 0 V 0 Easy +4 −0 updated 10/25/19, 20:44

Commit message

A cached page which uses RealUrl and config.absRefPrefix will not show
the AdminPanel if the URL contains a virtual path (e.g. /home/).

Reason: TSFE variables are not restored for cached pages.
This will lead to a wrong path for the adminpanel.css file.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Michael Stucki uploaded patch set 1 05/28/19, 11:49

  2. Michael Stucki commented on patch set 1 05/28/19, 11:51

    Note: This change is not needed for TYPO3 9.5 onwards.
  3. TYPO3com voted on patch set 1 V +1 05/28/19, 12:10 Completed build in 21m 14s on Tue, 28 May, 02:10 PM Test Summary: 80302 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3536

  4. Oliver Klee commented on patch set 1 05/28/19, 12:20

    9.5 and master are not affected?
  5. Michael Stucki commented on patch set 1 05/28/19, 13:22

    > Patch Set 1: > > (1 comment) Admin Panel and RealUrl have been replaced/rewritten in v9, and the problem as explained in #85945 does no longer happen (the AdminPanel is displayed regardless of the absRefPrefix setting). I can imagine that the hook_eofe is used to generate additional content, however this hook could easily call preparePageContentGeneration() if needed. To sum it up, I don't think it makes sense to forward-port this fix to v9 / master since the original problem is now gone.
  6. Tobi Kretschmann voted on patch set 1 CR +1 05/28/19, 19:46

  7. Susi Moog abandoned the change 10/25/19, 20:44

    8.7 is in critical bug fix phase, therefor we are abandoning this now.