Review main Merged

60835[TASK] Disable interface constructor in NodeFactoryTest

Anja Leichsenring CR +2 V +2 Easy +6 −6 updated 05/29/19, 08:03

Commit message

phpunit/phpunit changed in their latest release the handling of
interface constructor mocking.
Some of the tests reacted to this change and needed to be adjusted.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Guido Schmechel +1
    • Jan Stockfisch +1
    • Mathias Brodala +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Anja Leichsenring uploaded patch set 1 05/29/19, 07:26

  2. Anja Leichsenring updated the commit message in patch set 2 05/29/19, 07:28

  3. Mathias Brodala voted on patch set 2 CR +1 05/29/19, 07:28

  4. Jan Stockfisch voted on patch set 2 CR +1 05/29/19, 07:34

  5. TYPO3com voted on patch set 1 V +1 05/29/19, 07:42 Completed build in 15m 27s on Wed, 29 May, 09:42 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34077

  6. TYPO3com voted on patch set 2 V +1 05/29/19, 07:42 Completed build in 14m 06s on Wed, 29 May, 09:42 AM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34078

  7. Guido Schmechel voted on patch set 2 CR +1 05/29/19, 07:43

  8. Mathias Brodala commented on patch set 2 V +1 05/29/19, 07:45

    Verified by Bamboo.
  9. Oliver Hader voted on patch set 2 CR +1 05/29/19, 08:02

  10. Frank Nägler voted on patch set 2 V +2 CR +2 05/29/19, 08:03

  11. Frank Nägler merged patch set 3 05/29/19, 08:03