60841[TASK] Ensure PageArgumentValidator is not dependent on TSFE
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Daniel Gorges +1
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Daniel Gorges +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+11 −0
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php2+83 −39
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+47 −4
Review log 1318
-
Benni Mack uploaded patch set 1 05/29/19, 20:49
-
TYPO3com voted on patch set 1 V +1 05/29/19, 21:02 Completed build in 12m 59s on Wed, 29 May, 11:02 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34095
-
Benni Mack updated the commit message in patch set 2 05/29/19, 21:08
-
TYPO3com voted on patch set 2 V +1 05/29/19, 21:26 Completed build in 17m 41s on Wed, 29 May, 11:26 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34097
-
Oliver Hader commented on patch set 2 06/06/19, 15:48
-
Benni Mack uploaded patch set 3 06/06/19, 19:15
-
TYPO3com voted on patch set 3 V +1 06/06/19, 19:29 Completed build in 13m 50s on Thu, 6 Jun, 09:29 PM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34230
-
Andreas Kienast commented on patch set 3 06/07/19, 08:06
PageArgumentValidator.php:82UnresolvedCan we merge the if() and elseif() conditions to avoid the empty block? -
Andreas Kienast voted on patch set 3 V +1 06/07/19, 08:09
-
Benni Mack uploaded patch set 4 06/14/19, 11:02
-
TYPO3com voted on patch set 4 V -1 06/14/19, 11:17 Completed build in 14m 51s on Fri, 14 Jun, 01:17 PM Test Summary: 3584 of 46877 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34346
-
Benni Mack uploaded patch set 5 06/14/19, 12:10
-
TYPO3com voted on patch set 5 V +1 06/14/19, 12:26 Completed build in 15m 15s on Fri, 14 Jun, 02:26 PM Test Summary: 46538 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34347
-
Andreas Kienast voted on patch set 5 CR +1 06/14/19, 12:29
-
Daniel Gorges voted on patch set 5 V +1 CR +1 06/25/19, 04:30
-
Anja Leichsenring voted on patch set 5 V +2 06/26/19, 15:26
-
Anja Leichsenring voted on patch set 5 CR +2 06/26/19, 15:26
-
Anja Leichsenring merged patch set 6 06/26/19, 15:26
PageArgumentValidator.php:72Unresolved