Review main Merged

60841[TASK] Ensure PageArgumentValidator is not dependent on TSFE

Benni Mack CR +2 V +2 Normal +143 −43 updated 06/26/19, 15:26

Commit message

Checking if cHash matches any GET parameters can be
done without $TSFE->cHash_array and $TSFE->hash as
all data is built inside PageArguments already.

However, $TSFE->cHash_array is still necessary and
filled as before when ->setPageArguments() is called.

This is a precursor to re-structure the dependencies within
TSFE and PSR-15 middlewares.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Gorges +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1318

  1. Benni Mack uploaded patch set 1 05/29/19, 20:49

  2. TYPO3com voted on patch set 1 V +1 05/29/19, 21:02 Completed build in 12m 59s on Wed, 29 May, 11:02 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34095

  3. Benni Mack updated the commit message in patch set 2 05/29/19, 21:08

  4. TYPO3com voted on patch set 2 V +1 05/29/19, 21:26 Completed build in 17m 41s on Wed, 29 May, 11:26 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34097

  5. Oliver Hader commented on patch set 2 06/06/19, 15:48

    PageArgumentValidator.php:72 Unresolved

    This would fail in case $pageArguments is null (not defined, e.g. when using a different middleware to pre-process the request). In case this is a requirement we should explicitly throw an exception in case PageArguments are not given. If it's optional, now regular $request->queryParams would not be verified anymore.
  6. Benni Mack uploaded patch set 3 06/06/19, 19:15

  7. TYPO3com voted on patch set 3 V +1 06/06/19, 19:29 Completed build in 13m 50s on Thu, 6 Jun, 09:29 PM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34230

  8. Andreas Kienast commented on patch set 3 06/07/19, 08:06

    PageArgumentValidator.php:82 Unresolved

    Can we merge the if() and elseif() conditions to avoid the empty block?
  9. Andreas Kienast voted on patch set 3 V +1 06/07/19, 08:09

  10. Benni Mack uploaded patch set 4 06/14/19, 11:02

  11. TYPO3com voted on patch set 4 V -1 06/14/19, 11:17 Completed build in 14m 51s on Fri, 14 Jun, 01:17 PM Test Summary: 3584 of 46877 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34346

  12. Benni Mack uploaded patch set 5 06/14/19, 12:10

  13. TYPO3com voted on patch set 5 V +1 06/14/19, 12:26 Completed build in 15m 15s on Fri, 14 Jun, 02:26 PM Test Summary: 46538 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34347

  14. Andreas Kienast voted on patch set 5 CR +1 06/14/19, 12:29

  15. Daniel Gorges voted on patch set 5 V +1 CR +1 06/25/19, 04:30

  16. Anja Leichsenring voted on patch set 5 V +2 06/26/19, 15:26

  17. Anja Leichsenring voted on patch set 5 CR +2 06/26/19, 15:26

  18. Anja Leichsenring merged patch set 6 06/26/19, 15:26