60844[BUGFIX] Ensure no PHP warning is thrown if legacy code is used
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Michael Waack +1
- Frank Nägler +1
- Thomas Anders +1
-
Verified V +2 Done
- Benni Mack +2
- Michael Waack +1
- Thomas Anders +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1112
-
Benni Mack uploaded patch set 1 05/29/19, 21:35
-
TYPO3com voted on patch set 1 V +1 05/29/19, 21:47 Completed build in 12m 05s on Wed, 29 May, 11:47 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34101
-
Michael Waack voted on patch set 1 CR +1 05/31/19, 05:31
-
Michael Waack voted on patch set 1 V +1 05/31/19, 06:03
-
Frank Nägler commented on patch set 1 CR +1 05/31/19, 07:01
the patch looks good, but I have no system to verify the fix -
Michael Waack commented on patch set 1 05/31/19, 07:06
> Patch Set 1: Code-Review+1 > > the patch looks good, but I have no system to verify the fix I have verified on Mittwald-Server and works fine -
Frank Nägler commented on patch set 1 V -1 05/31/19, 09:12
temporary -1 for Benni, he will check this patch -
Frank Nägler voted on patch set 1 V 0 06/05/19, 11:11
-
Thomas Anders voted on patch set 1 V +1 CR +1 06/05/19, 11:12
-
Benni Mack commented on patch set 1 V +2 CR +2 06/05/19, 11:39
As there is no core merger available with Mittwald hosting, I take the liberty to merge this one. -
Benni Mack merged patch set 2 06/05/19, 11:39
-
Claus Due commented on patch set 2 06/05/19, 12:19
Post-review (copied from cherry-pick counterpart): Since `constant()` returns NULL if a constant is not defined, you can null-coalesce this and avoid declaring a constant that does not belong to TYPO3. If the constant is also used by the polyfill itself (not just the argument) then that should be reported to the proper bug tracker. return \Symfony\Polyfill\Intl\Idn\Idn::idn_to_ascii($domain, IDNA_DEFAULT, constant('INTL_IDNA_VARIANT_UTS46') ?? constant('TYPO3_IDN_TO_ASCII_USE_COMPAT') ?? 1);