Review 9.5 Merged

60845[BUGFIX] Add initialization of DataMapper on QueryResult object wakeup

TYPO3com CR +2 V +2 Easy +1 −0 updated 10/22/19, 07:54

Commit message

`DataMapper` object initialization is missed in this place.
And it leads to error `Call to a member function map() on null` when
`QueryResult` object retrieved from cache.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1318

  1. TYPO3com uploaded patch set 1 05/30/19, 10:01

  2. TYPO3com voted on patch set 1 V +1 05/30/19, 10:12 Completed build in 11m 16s on Thu, 30 May, 12:12 PM Test Summary: 50341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-737

  3. Oliver Klee commented on patch set 1 CR -1 05/30/19, 13:06

    I'm not sure that "wak" is a word.
  4. Ayke Halder updated the commit message in patch set 2 06/07/19, 23:30

  5. TYPO3com voted on patch set 2 V +1 06/07/19, 23:42 Completed build in 11m 48s on Sat, 8 Jun, 01:42 AM Test Summary: 50393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-768

  6. Oliver Klee voted on patch set 2 CR +1 06/07/19, 23:45

  7. Oliver Klee voted on patch set 2 CR 0 06/07/19, 23:46

  8. Tymoteusz Motylewski commented on patch set 2 CR -1 06/08/19, 20:23

    Is this patch relevant to v9 only? If its also relevant for master, this patch should be first pushed against master branch , not 9.5 (the backport to 9.5 will be done be the core team member who merged it). And the Releases line should contain „9.5, master”
  9. Tymoteusz Motylewski wrote 07/05/19, 08:43

    Topic set to extbase
  10. Alexander Schnitzler commented on patch set 2 07/05/19, 10:11

    I'd like to know when this happens. When serializing und unserializing a QueryResult, of course, but what's the exact use case here?
  11. Oliver Klee updated the commit message in patch set 3 07/05/19, 10:57

  12. TYPO3com voted on patch set 3 V +1 07/05/19, 11:18 Completed build in 15m 42s on Fri, 5 Jul, 01:18 PM Test Summary: 50475 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-868

  13. Alexander Schnitzler commented on patch set 3 CR -2 07/05/19, 11:44

    btw: this patch has been pushed to the 9.5 branch. If we want to fix this, we should do so in master, first.
  14. Alexander Schnitzler uploaded patch set 4 10/21/19, 17:17

  15. Alexander Schnitzler wrote 10/21/19, 17:17

    Removed Code-Review-2 by Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
  16. TYPO3com voted on patch set 4 V +1 10/21/19, 17:30 Completed build in 13m 16s on Mon, 21 Oct, 05:30 PM Test Summary: 50765 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1344

  17. Alexander Schnitzler voted on patch set 4 V +2 CR +2 10/22/19, 07:54

  18. Alexander Schnitzler merged patch set 5 10/22/19, 07:54