Review 9.5 Merged

60850[TASK] Write cleaner FileWriter JSON output

Frank Nägler CR +2 V +2 Easy +23 −1 updated 05/31/19, 11:14

Commit message

Since PHP 5.4 it's possible to disable escaping for unicode characters
and slashes, which results in a much cleaner, leaner and most
importantly readable TYPO3 log output.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 45

  1. Frank Nägler commented on patch set 1 05/31/19, 10:58

    Cherry Picked from branch master.
  2. Oliver Klee voted on patch set 1 CR +1 05/31/19, 11:08

  3. TYPO3com voted on patch set 1 V +1 05/31/19, 11:12 Completed build in 13m 39s on Fri, 31 May, 01:12 PM Test Summary: 50357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-742

  4. Frank Nägler voted on patch set 1 V +2 CR +2 05/31/19, 11:14

  5. Frank Nägler merged patch set 2 05/31/19, 11:14