60860[TASK] Open LinkBrowser in modal window
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Markus Klein +1
-
Verified V +2 Done
- Daniel Goerz +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/FieldControl/LinkPopup.ts2new+50 −0
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+9 −17
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FieldControl/LinkPopup.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngineLinkBrowserAdapter.js+43 −7
Review log 1215
-
Andreas Kienast uploaded patch set 1 06/01/19, 21:05
-
TYPO3com voted on patch set 1 V +1 06/01/19, 21:18 Completed build in 13m 06s on Sat, 1 Jun, 11:18 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34130
-
Andreas Kienast uploaded patch set 2 06/01/19, 21:39
-
TYPO3com voted on patch set 2 V +1 06/01/19, 21:52 Completed build in 12m 49s on Sat, 1 Jun, 11:52 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34132
-
Guido Schmechel voted on patch set 2 V +1 06/02/19, 08:46
-
Frank Nägler voted on patch set 2 CR +1 06/02/19, 09:45
-
Frank Nägler voted on patch set 2 V +1 06/02/19, 09:51
-
Riccardo De Contardi commented on patch set 2 V +1 06/02/19, 15:51
tested with tt_content header link -
Markus Klein voted on patch set 2 V +1 06/05/19, 07:28
-
Markus Klein commented on patch set 2 06/05/19, 07:30
LinkPopup.ts:34this function name is misleading. This function does not register the click handler, it *is* the click handler -
Andreas Kienast uploaded patch set 3 06/05/19, 10:23
-
Markus Klein commented on patch set 3 V +1 CR +1 06/05/19, 10:26
LinkPopup.ts:34ReplyDone -
TYPO3com voted on patch set 3 V +1 06/05/19, 10:36 Completed build in 13m 05s on Wed, 5 Jun, 12:36 PM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34193
-
Daniel Goerz voted on patch set 3 V +2 CR +2 06/05/19, 18:41
-
Daniel Goerz merged patch set 4 06/05/19, 18:41