Review main Merged Breaking

60861[!!!][TASK] Remove `additionalJavaScriptSubmit` from FormEngine

Andreas Kienast CR +2 V +2 Normal +65 −151 updated 07/05/19, 13:32

Commit message

With RequireJS in place, it is possible to minimize the amount of inline
JavaScript in the backend. This patch removes FormEngine's
`additionalJavaScriptSubmit` feature that registers additional submit
handlers and allows to abort the form submission.

This feature is rarely used at all, but can be achieved using a RequireJS
module that registers a callback in `TYPO3/CMS/Backend/DocumentSaveActions`.

Since the feature is gone, a lot of global code within TBE_EDITOR is
removed as well.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1930

Show 35 earlier messages
  1. Andreas Kienast uploaded patch set 1 06/02/19, 16:51

  2. TYPO3com voted on patch set 1 V +1 06/02/19, 17:06 Completed build in 14m 20s on Sun, 2 Jun, 07:06 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34136

  3. Andreas Kienast uploaded patch set 2 06/29/19, 06:21

  4. TYPO3com voted on patch set 2 V +1 06/29/19, 06:30 Completed build in 09m 47s on Sat, 29 Jun, 08:30 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34631

  5. Andreas Kienast uploaded patch set 3 06/30/19, 05:36

  1. TYPO3com voted on patch set 3 V +1 06/30/19, 05:46 Completed build in 09m 43s on Sun, 30 Jun, 07:46 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34651

  2. Andreas Kienast uploaded patch set 4 07/01/19, 10:18

  3. TYPO3com voted on patch set 4 V -1 07/01/19, 10:28 Completed build in 10m 23s on Mon, 1 Jul, 12:28 PM Test Summary: 13 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34676

  4. Andreas Kienast uploaded patch set 5 07/01/19, 11:27

  5. TYPO3com voted on patch set 5 V -1 07/01/19, 11:29 Completed build in 24s on Mon, 1 Jul, 01:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34686

  6. Andreas Kienast uploaded patch set 6 07/01/19, 11:33

  7. TYPO3com voted on patch set 6 V -1 07/01/19, 11:42 Completed build in 09m 23s on Mon, 1 Jul, 01:42 PM Test Summary: 13 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34687

  8. Andreas Kienast uploaded patch set 7 07/01/19, 11:58

  9. TYPO3com voted on patch set 7 V +1 07/01/19, 12:09 Completed build in 11m 26s on Mon, 1 Jul, 02:09 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34690

  10. Andreas Kienast uploaded patch set 8 07/01/19, 12:24

  11. TYPO3com voted on patch set 8 V +1 07/01/19, 12:33 Completed build in 08m 55s on Mon, 1 Jul, 02:33 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34691

  12. Andreas Kienast uploaded patch set 9 07/01/19, 14:57

  13. TYPO3com voted on patch set 9 V +1 07/01/19, 15:08 Completed build in 10m 16s on Mon, 1 Jul, 05:08 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34692

  14. Andreas Kienast commented on patch set 10 07/01/19, 17:28

    Published edit on patch set 9.
  15. TYPO3com voted on patch set 10 V +1 07/01/19, 17:38 Completed build in 09m 47s on Mon, 1 Jul, 07:38 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34698

  16. Anja Leichsenring commented on patch set 11 07/05/19, 10:23

    Published edit on patch set 10.
  17. Anja Leichsenring voted on patch set 11 V +1 CR +1 07/05/19, 10:31

  18. TYPO3com voted on patch set 11 V +1 07/05/19, 10:34 Completed build in 10m 31s on Fri, 5 Jul, 12:34 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34796

  19. Oliver Hader commented on patch set 11 CR +1 07/05/19, 10:59

    Would it be possible to detect usages of `additionalJavaScriptSubmit` with extension scanner?
  20. Andreas Kienast commented on patch set 11 07/05/19, 11:04

    > Patch Set 11: Code-Review+1 > > Would it be possible to detect usages of `additionalJavaScriptSubmit` with extension scanner? AFAICS extension scanner doesn't support single array keys, but "whole arrays", e.g. as `$childReturn['additionalJavaScriptSubmit']`.
  21. Frank Nägler commented on patch set 11 CR -1 07/05/19, 12:56

    on it
  22. Andreas Kienast commented on patch set 11 CR -2 07/05/19, 12:59

    Patch depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/61204 being merged before
  23. Andreas Kienast voted on patch set 11 CR 0 07/05/19, 13:23

  24. Frank Nägler voted on patch set 11 V +2 CR +2 07/05/19, 13:32

  25. Frank Nägler merged patch set 12 07/05/19, 13:32