60861[!!!][TASK] Remove `additionalJavaScriptSubmit` from FormEngine
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
- Oliver Hader +1
-
Verified V +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DocumentSaveActions.ts+1 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+0 −1
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+0 −5
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+0 −5
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+0 −5
- typo3/sysext/backend/Classes/Form/AbstractNode.php+0 −4
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+3 −25
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Edit.html+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DocumentSaveActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js+6 −3
- typo3/sysext/backend/Resources/Public/JavaScript/jsfunc.tbe_editor.js+0 −96
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+0 −3
- typo3/sysext/backend/Tests/Unit/Form/Element/InputDateTimeElementTest.php+0 −1
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88667-RemovedAdditionalJavaScriptSubmitFromFormEngine.rstnew+54 −0
Review log 1930
Show 35 earlier messages
-
Andreas Kienast uploaded patch set 1 06/02/19, 16:51
-
TYPO3com voted on patch set 1 V +1 06/02/19, 17:06 Completed build in 14m 20s on Sun, 2 Jun, 07:06 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34136
-
Andreas Kienast uploaded patch set 2 06/29/19, 06:21
-
TYPO3com voted on patch set 2 V +1 06/29/19, 06:30 Completed build in 09m 47s on Sat, 29 Jun, 08:30 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34631
-
Andreas Kienast uploaded patch set 3 06/30/19, 05:36
-
TYPO3com voted on patch set 3 V +1 06/30/19, 05:46 Completed build in 09m 43s on Sun, 30 Jun, 07:46 AM Test Summary: 46832 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34651
-
Andreas Kienast uploaded patch set 4 07/01/19, 10:18
-
TYPO3com voted on patch set 4 V -1 07/01/19, 10:28 Completed build in 10m 23s on Mon, 1 Jul, 12:28 PM Test Summary: 13 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34676
-
Andreas Kienast uploaded patch set 5 07/01/19, 11:27
-
TYPO3com voted on patch set 5 V -1 07/01/19, 11:29 Completed build in 24s on Mon, 1 Jul, 01:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34686
-
Andreas Kienast uploaded patch set 6 07/01/19, 11:33
-
TYPO3com voted on patch set 6 V -1 07/01/19, 11:42 Completed build in 09m 23s on Mon, 1 Jul, 01:42 PM Test Summary: 13 of 47199 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34687
-
Andreas Kienast uploaded patch set 7 07/01/19, 11:58
-
TYPO3com voted on patch set 7 V +1 07/01/19, 12:09 Completed build in 11m 26s on Mon, 1 Jul, 02:09 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34690
-
Andreas Kienast uploaded patch set 8 07/01/19, 12:24
-
TYPO3com voted on patch set 8 V +1 07/01/19, 12:33 Completed build in 08m 55s on Mon, 1 Jul, 02:33 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34691
-
Andreas Kienast uploaded patch set 9 07/01/19, 14:57
-
TYPO3com voted on patch set 9 V +1 07/01/19, 15:08 Completed build in 10m 16s on Mon, 1 Jul, 05:08 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34692
-
Andreas Kienast commented on patch set 10 07/01/19, 17:28
Published edit on patch set 9. -
TYPO3com voted on patch set 10 V +1 07/01/19, 17:38 Completed build in 09m 47s on Mon, 1 Jul, 07:38 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34698
-
Anja Leichsenring commented on patch set 11 07/05/19, 10:23
Published edit on patch set 10. -
Anja Leichsenring voted on patch set 11 V +1 CR +1 07/05/19, 10:31
-
TYPO3com voted on patch set 11 V +1 07/05/19, 10:34 Completed build in 10m 31s on Fri, 5 Jul, 12:34 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34796
-
Oliver Hader commented on patch set 11 CR +1 07/05/19, 10:59
Would it be possible to detect usages of `additionalJavaScriptSubmit` with extension scanner? -
Andreas Kienast commented on patch set 11 07/05/19, 11:04
> Patch Set 11: Code-Review+1 > > Would it be possible to detect usages of `additionalJavaScriptSubmit` with extension scanner? AFAICS extension scanner doesn't support single array keys, but "whole arrays", e.g. as `$childReturn['additionalJavaScriptSubmit']`. -
Frank Nägler commented on patch set 11 CR -1 07/05/19, 12:56
on it -
Andreas Kienast commented on patch set 11 CR -2 07/05/19, 12:59
Patch depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/61204 being merged before -
Andreas Kienast voted on patch set 11 CR 0 07/05/19, 13:23
-
Frank Nägler voted on patch set 11 V +2 CR +2 07/05/19, 13:32
-
Frank Nägler merged patch set 12 07/05/19, 13:32