60862[TASK] Add title to topbar buttons
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Oliver Klee +1
- Sybille Peters +1
-
Verified V +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Sybille Peters +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1115
-
Gianluigi Martino uploaded patch set 1 06/03/19, 07:15
-
TYPO3com voted on patch set 1 V +1 06/03/19, 07:30 Completed build in 15m 05s on Mon, 3 Jun, 09:30 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34139
-
Riccardo De Contardi commented on patch set 1 V +1 06/03/19, 19:56
maybe also `aria-label` could be added with the same text? I don't remember well, but if I am not wrong, often the screen readers are configured to skip the title attribute. -
Oliver Klee commented on patch set 2 06/03/19, 20:11
Published edit on patch set 1. -
Oliver Klee updated the commit message in patch set 3 06/03/19, 20:11
-
Sybille Peters voted on patch set 3 V +1 CR +1 06/03/19, 20:19
-
TYPO3com voted on patch set 3 V +1 06/03/19, 20:25 Completed build in 13m 49s on Mon, 3 Jun, 10:25 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34158
-
TYPO3com voted on patch set 2 V +1 06/03/19, 20:26 Completed build in 15m 12s on Mon, 3 Jun, 10:26 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34157
-
Daniel Goerz updated the commit message in patch set 4 06/05/19, 19:04
-
Daniel Goerz commented on patch set 4 V +1 CR +1 06/05/19, 19:05
I would not introduce new labels to 8.7 since this is not a "critical" patch. 9.5 is fine, though. -
TYPO3com voted on patch set 4 V +1 06/05/19, 19:17 Completed build in 12m 26s on Wed, 5 Jun, 09:17 PM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34207
-
Sybille Peters voted on patch set 4 V +1 CR +1 06/06/19, 06:24
-
Oliver Klee voted on patch set 4 CR +1 06/06/19, 10:52
-
Georg Ringer voted on patch set 4 V +2 CR +2 06/12/19, 05:56
-
Georg Ringer merged patch set 5 06/12/19, 05:56