Review main Merged

60863[TASK] Set locale for requests earlier in Frontend process

Benni Mack CR +2 V +2 Normal +163 −22 updated 06/05/19, 04:47

Commit message

Due to non-site handling, setting the locale was built on top of
TypoScript settings. This was the reason, this was encapsulated
within "$TSFE->settingLocale()".

However, as the locale is now always available once SiteLanguage
has been resolved, this can be handled very early.

On top, the functionaltiy can be extracted from TSFE completely,
and be universally used within "Locales".

The method $TSFE->settingLocale() is now deprecated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1015

  1. Benni Mack uploaded patch set 1 06/03/19, 07:15

  2. TYPO3com voted on patch set 1 V -1 06/03/19, 07:31 Completed build in 15m 25s on Mon, 3 Jun, 09:31 AM Test Summary: 1 of 46829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34140

  3. TYPO3com voted on patch set 1 V +1 06/03/19, 07:56 Completed build in 56m 07s on Mon, 3 Jun, 09:56 AM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34140

  4. Achim Fritz voted on patch set 1 CR +1 06/03/19, 09:07

  5. Georg Ringer voted on patch set 1 V +1 CR +1 06/03/19, 09:56

  6. Anja Leichsenring commented on patch set 2 06/03/19, 14:41

    Published edit on patch set 1.
  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/03/19, 14:43

  8. TYPO3com voted on patch set 2 V -1 06/03/19, 14:55 Completed build in 14m 01s on Mon, 3 Jun, 04:55 PM Test Summary: 1 of 46829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34146

  9. Anja Leichsenring rebased onto patch set 3 06/03/19, 16:30

  10. TYPO3com voted on patch set 3 V -1 06/03/19, 16:43 Completed build in 13m 07s on Mon, 3 Jun, 06:43 PM Test Summary: 1 of 46829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34153

  11. Benni Mack uploaded patch set 4 06/04/19, 05:56

  12. TYPO3com voted on patch set 4 V +1 06/04/19, 06:12 Completed build in 15m 16s on Tue, 4 Jun, 08:12 AM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34162

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/04/19, 06:12

  14. Andreas Kienast voted on patch set 4 V +2 CR +2 06/05/19, 04:46

  15. Andreas Kienast merged patch set 5 06/05/19, 04:47