Review main Merged

60864[TASK] Prepare cache timeout more efficiently in Frontend

Benni Mack CR +2 V +2 Easy +16 −12 updated 06/04/19, 13:57

Commit message

Cache Timeout, configured via config.cache_period can be configured
when TypoScript is available.

The functionality $TSFE->generatePage_preProcessing() has been
thinned out further, as custom PHP Scripts are now handled via custom
RequestHandlers anyway, which now rely on this information
being set earlier (and also when a page should not be generated).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Benni Mack uploaded patch set 1 06/03/19, 08:34

  2. TYPO3com voted on patch set 1 V +1 06/03/19, 08:47 Completed build in 13m 36s on Mon, 3 Jun, 10:47 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34141

  3. Benjamin Franzke voted on patch set 1 CR +1 06/03/19, 08:54

  4. Markus Klein commented on patch set 1 CR -1 06/04/19, 07:39

    TypoScriptFrontendController.php:3315 Unresolved

    I would add a check here to make sure $seconds is >= 0.

    TypoScriptFrontendController.php:3336 Unresolved

    I somehow dislike that we have this default value now in 3 places and not even in a constant.
  5. Benni Mack uploaded patch set 2 06/04/19, 08:33

  6. TYPO3com voted on patch set 2 V +1 06/04/19, 08:43 Completed build in 10m 04s on Tue, 4 Jun, 10:43 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34166

  7. Markus Klein commented on patch set 3 06/04/19, 08:48

    Published edit on patch set 2.
  8. Markus Klein voted on patch set 3 V +1 CR +1 06/04/19, 08:49

  9. TYPO3com voted on patch set 3 V +1 06/04/19, 09:02 Completed build in 13m 37s on Tue, 4 Jun, 11:02 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34167

  10. Benjamin Franzke voted on patch set 3 V +2 CR +2 06/04/19, 13:57

  11. Benjamin Franzke merged patch set 4 06/04/19, 13:57