Review main Merged

60868[BUGFIX] Raise codeception and phpunit versions

Anja Leichsenring CR +2 V +2 Hard +695 −121 updated 06/03/19, 18:36

Commit message

With #88388, the composer.json file was adjusted to the required
versions of

phpunit/phpunit ^8.1
codeception/codeception ^3

but the composer.lock file did not reflect these changes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Anja Leichsenring uploaded patch set 1 06/03/19, 15:11

  2. Anja Leichsenring uploaded patch set 2 06/03/19, 15:20

  3. TYPO3com voted on patch set 1 V +1 06/03/19, 15:28 Completed build in 16m 21s on Mon, 3 Jun, 05:28 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34150

  4. TYPO3com voted on patch set 2 V +1 06/03/19, 15:30 Completed build in 09m 23s on Mon, 3 Jun, 05:30 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34152

  5. Benni Mack voted on patch set 2 V +2 CR +2 06/03/19, 17:58

  6. Benni Mack merged patch set 3 06/03/19, 17:58

  7. Jonas Eberle commented on patch set 2 V +1 06/03/19, 18:36

    All local test suites with Build/Scripts/runTests.sh still run and don't show errors (bamboo would have probably found out already if that was not the case). Not sure what else to test. `composer install` gives: Loading composer repositories with package information Installing dependencies (including require-dev) from lock file Package operations: 9 installs, 16 updates, 0 removals - Updating symfony/polyfill-ctype (v1.10.0 => v1.11.0): Loading from cache - Updating symfony/contracts (v1.0.2 => v1.1.2): Loading from cache - Updating symfony/event-dispatcher (v4.2.3 => v4.3.0): Downloading (100%) - Updating symfony/dom-crawler (v4.2.3 => v4.3.0): Downloading (100%) - Updating symfony/css-selector (v4.2.3 => v4.3.0): Downloading (100%) - Updating symfony/browser-kit (v4.2.3 => v4.3.0): Downloading (100%) - Installing hoa/exception (1.17.01.16): Downloading (100%) - Installing hoa/consistency (1.17.05.02): Downloading (100%) - Installing hoa/event (1.17.01.13): Downloading (100%) - Installing hoa/ustring (4.17.01.16): Downloading (100%) - Installing hoa/protocol (1.17.01.14): Downloading (100%) - Installing hoa/stream (1.17.02.21): Downloading (100%) - Installing hoa/iterator (2.17.01.10): Downloading (100%) - Installing hoa/file (1.17.07.11): Downloading (100%) - Installing hoa/console (3.17.05.02): Downloading (100%) - Updating symfony/process (v4.2.3 => v4.3.0): Downloading (100%) - Updating sebastian/global-state (2.0.0 => 3.0.0): Downloading (100%) - Updating sebastian/environment (4.1.0 => 4.2.2): Downloading (100%) - Updating theseer/tokenizer (1.1.0 => 1.1.2): Downloading (100%) - Updating phpunit/php-code-coverage (6.1.4 => 7.0.4): Downloading (100%) - Updating myclabs/deep-copy (1.8.1 => 1.9.1): Downloading (100%) - Updating phpunit/phpunit (7.5.6 => 8.1.6): Downloading (100%) - Updating codeception/phpunit-wrapper (7.7.1 => 8.0.4): Downloading (100%) - Updating codeception/stub (2.0.4 => 2.1.0): Downloading (100%) - Updating codeception/codeception (2.5.4 => 3.0.1): Downloading (100%)