60869[BUGFIX] Remove side effect of unit test
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
Issues 1
Files 1
Review log 1012
-
Anja Leichsenring uploaded patch set 1 06/03/19, 16:30
-
TYPO3com voted on patch set 1 V +1 06/03/19, 16:45 Completed build in 14m 48s on Mon, 3 Jun, 06:45 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34154
-
Oliver Klee commented on patch set 1 CR -1 06/03/19, 17:51
-
Benni Mack uploaded patch set 2 06/04/19, 05:41
-
Benni Mack uploaded patch set 3 06/04/19, 05:45
-
Benni Mack voted on patch set 3 V +1 CR +1 06/04/19, 05:45
-
Georg Ringer voted on patch set 3 V +2 CR +2 06/04/19, 05:49
-
Georg Ringer merged patch set 4 06/04/19, 05:50
-
Benni Mack commented on patch set 4 06/04/19, 05:53
No backport needed as the affected changes just gets introduced within the next change. In fact, we should have added this "fix" in the other change. -
Anja Leichsenring commented on patch set 4 06/04/19, 05:57
> Patch Set 4: > > No backport needed as the affected changes just gets introduced within the next change. In fact, we should have added this "fix" in the other change. that is not correct, I managed to fail another test in random mode without the patch you mention. The side effect should be removed also in lower versions. -
Benni Mack commented on patch set 4 06/04/19, 05:58
how? -
TYPO3com voted on patch set 3 V +1 06/04/19, 06:00 Completed build in 15m 01s on Tue, 4 Jun, 08:00 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34160
SiteResolverTest.php:381