Review main Merged Breaking

60875[!!!][TASK] Re-organize variable initialization for User Authentication

Benni Mack CR +2 V +2 Hard +174 −78 updated 06/14/19, 19:32

Commit message

There are a lot of places where AbstractUserAuthentication
and the dependents (BE/FE user auth) set various settings,
both in the constructor and the start() method.

All possible settings are now moved to the constructor,
or to dependent properties in subclasses.

Some changes are now in place:
- UserAuth->loginType must be set now (which was previously
  in start()). This is now checked in the constructor.
- Most of the variables (sessionTimeout/sessionDateLifetime) are
  now set and evaluated inside the constructor, making start()
  much simpler to understand and read.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2031

Show 36 earlier messages
  1. Benni Mack uploaded patch set 1 06/04/19, 11:01

  2. TYPO3com voted on patch set 1 V -1 06/04/19, 11:15 Completed build in 13m 45s on Tue, 4 Jun, 01:15 PM Test Summary: 2164 of 46817 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34170

  3. TYPO3com commented on patch set 1 06/04/19, 11:25 Completed build in 37m 19s on Tue, 4 Jun, 01:25 PM Test Summary: 519 of 46817 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34170

  4. Benni Mack rebased onto patch set 2 06/07/19, 05:20

  5. TYPO3com voted on patch set 2 V -1 06/07/19, 05:30 Completed build in 10m 41s on Fri, 7 Jun, 07:30 AM Test Summary: 368 of 46833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34233

  6. Benni Mack uploaded patch set 3 06/07/19, 16:05

  1. TYPO3com voted on patch set 3 V +1 06/07/19, 16:37 Completed build in 26m 53s on Fri, 7 Jun, 06:37 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34262

  2. Benni Mack updated the commit message in patch set 4 06/07/19, 17:14

  3. TYPO3com voted on patch set 4 V +1 06/07/19, 17:26 Completed build in 11m 53s on Fri, 7 Jun, 07:26 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34265

  4. Benni Mack updated the commit message in patch set 5 06/07/19, 18:58

  5. TYPO3com voted on patch set 5 V +1 06/07/19, 19:08 Completed build in 09m 20s on Fri, 7 Jun, 09:08 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34269

  6. Andreas Kienast uploaded patch set 6 06/07/19, 19:46

  7. Andreas Kienast commented on patch set 6 06/07/19, 19:47

    AbstractUserAuthentication.php:1031

    Should be check $id as well?
  8. Benni Mack commented on patch set 6 06/07/19, 19:47

    AbstractUserAuthentication.php:1031 Reply Unresolved

    Bug! Will fix
  9. Benni Mack commented on patch set 7 06/07/19, 19:48

    Published edit on patch set 6.
  10. Andreas Kienast voted on patch set 7 V +1 CR +1 06/07/19, 19:58

  11. TYPO3com voted on patch set 6 V +1 06/07/19, 20:01 Completed build in 14m 49s on Fri, 7 Jun, 10:01 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34270

  12. TYPO3com voted on patch set 7 V +1 06/07/19, 20:02 Completed build in 14m 16s on Fri, 7 Jun, 10:02 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34271

  13. Markus Klein commented on patch set 7 06/07/19, 21:13

    AbstractUserAuthentication.php:332

    must

    FrontendUserAuthentication.php:193

    This is a breaking change. Before one could instantiate this class, then adjust sessionTimeout and lifetime and then call start(). Now this kind of adjustment is no possible anymore. I am absolutely not sure how many extensions would be affected, I suppose this is a very small number. Still, technically this is a breaking change.
  14. Benni Mack commented on patch set 7 06/08/19, 19:25

    FrontendUserAuthentication.php:193 Reply

    yeah, good point. I mean, also looking at the adjustments in the Unit Tests for AbstractUserAuth shows that it's _technically_ breaking, thus I agree with you. I consider this change long overdue for this ugly construct of subclassing with so many public properties. Really, one of the worst APIs (worse than TSFE nowadays). I hope to create a couple of more patches in this area, so I'll be creating a "Breaking" document with changes regarding to User handling.
  15. Benni Mack uploaded patch set 8 06/13/19, 15:19

  16. TYPO3com voted on patch set 8 V +1 06/13/19, 15:33 Completed build in 14m 24s on Thu, 13 Jun, 05:33 PM Test Summary: 46524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34335

  17. Markus Klein commented on patch set 8 06/13/19, 16:26

    AbstractUserAuthentication.php:332 Reply

    Done

    FrontendUserAuthentication.php:193 Reply

    Ack
  18. Markus Klein commented on patch set 9 06/13/19, 19:21

    Published edit on patch set 8.
  19. Markus Klein updated the commit message in patch set 10 06/13/19, 19:21

  20. Markus Klein voted on patch set 10 CR +1 06/13/19, 19:21

  21. TYPO3com voted on patch set 9 V +1 06/13/19, 19:36 Completed build in 14m 41s on Thu, 13 Jun, 09:36 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34336

  22. TYPO3com voted on patch set 10 V +1 06/13/19, 19:37 Completed build in 15m 29s on Thu, 13 Jun, 09:37 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34337

  23. Andreas Kienast voted on patch set 10 V +1 CR +1 06/14/19, 12:14

  24. Georg Ringer voted on patch set 10 V +2 CR +2 06/14/19, 19:32

  25. Georg Ringer merged patch set 11 06/14/19, 19:32