Review main Merged

60877[TASK] Simplify Locales class

Benni Mack CR +2 V +2 Easy +16 −21 updated 06/05/19, 05:50

Commit message

The Locales class implies a kind-of singleton approach to fetch
configuration information.

In addition, Locales does the same functionality all over again:
- array_flip for "isoReverseMapping" (not in use directly and can be removed)
- taking the built-in supported languages and loops over them

both is unnecessary at runtime.

Instead, only the user-specific parts are validated.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 06/04/19, 14:12

  2. TYPO3com voted on patch set 1 V +1 06/04/19, 14:28 Completed build in 15m 29s on Tue, 4 Jun, 04:28 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34176

  3. Oliver Hader voted on patch set 1 CR +1 06/04/19, 14:39

  4. Andreas Kienast commented on patch set 1 V -1 06/05/19, 04:30

    "Manage Language Packs" in Install Tool fails: PHP Warning: Invalid argument supplied for foreach() in /var/www/src/master/typo3/sysext/core/Classes/Localization/Locales.php line 197
  5. Benni Mack uploaded patch set 2 06/05/19, 05:07

  6. TYPO3com voted on patch set 2 V +1 06/05/19, 05:17 Completed build in 09m 55s on Wed, 5 Jun, 07:17 AM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34183

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 06/05/19, 05:21

  8. Georg Ringer voted on patch set 2 V +2 CR +2 06/05/19, 05:50

  9. Georg Ringer merged patch set 3 06/05/19, 05:50