60878[TASK] Deprecate usage of $GLOBALS[LOCAL_LANG]
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
-
Verified V +2 Done
- Andreas Kienast +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+0 −4
- typo3/sysext/core/Classes/Localization/LanguageService.php3+51 −9
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88567-GLOBALS_LOCAL_LANG.rstnew+50 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayGlobalMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php2+6 −0
Review log 1926
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 06/04/19, 14:17
-
TYPO3com voted on patch set 1 V +1 06/04/19, 14:30 Completed build in 12m 53s on Tue, 4 Jun, 04:30 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34177
-
Benni Mack uploaded patch set 2 06/14/19, 19:43
-
TYPO3com voted on patch set 2 V +1 06/14/19, 20:01 Completed build in 18m 37s on Fri, 14 Jun, 10:01 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34354
-
Andreas Kienast commented on patch set 2 CR -1 06/17/19, 11:29
-
Benni Mack commented on patch set 3 06/17/19, 12:33
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 06/17/19, 12:49 Completed build in 16m 40s on Mon, 17 Jun, 02:49 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34382
-
Benni Mack uploaded patch set 4 06/28/19, 12:02
-
TYPO3com voted on patch set 4 V +1 06/28/19, 12:15 Completed build in 12m 50s on Fri, 28 Jun, 02:15 PM Test Summary: 46517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34608
-
Andreas Kienast commented on patch set 5 06/28/19, 13:16
Published edit on patch set 4. -
Andreas Kienast voted on patch set 5 V +1 CR +1 06/28/19, 13:16
-
TYPO3com voted on patch set 5 V +1 06/28/19, 13:27 Completed build in 11m 41s on Fri, 28 Jun, 03:27 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34610
-
Daniel Goerz commented on patch set 5 06/28/19, 15:25
MethodArgumentDroppedMatcher.php:233Shouldn't this be 1, as the 2nd and 3rd argument are now deprecated? -
Benni Mack commented on patch set 6 06/28/19, 15:26
Published edit on patch set 5. -
Benni Mack commented on patch set 6 06/28/19, 15:26
MethodArgumentDroppedMatcher.php:233Replydone -
Daniel Goerz voted on patch set 6 CR +1 06/28/19, 15:29
-
TYPO3com voted on patch set 6 V +1 06/28/19, 15:36 Completed build in 09m 50s on Fri, 28 Jun, 05:36 PM Test Summary: 46826 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34620
-
Oliver Klee commented on patch set 6 06/28/19, 15:47
LanguageService.php:76If this is an array of strings (which I'm currently not sure of), we can change to annotation to @var string[] to help static analysis (and to help the reader). -
Benni Mack commented on patch set 6 06/28/19, 18:17
LanguageService.php:76Replyit's an array of array of strings $this->labels[$language][key] = 'label'; -
Oliver Klee commented on patch set 7 07/01/19, 11:09
Published edit on patch set 6. -
Oliver Klee commented on patch set 7 07/01/19, 11:09
LanguageService.php:76ReplyDone -
TYPO3com voted on patch set 7 V +1 07/01/19, 11:27 Completed build in 13m 36s on Mon, 1 Jul, 01:27 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34683
-
Benni Mack commented on patch set 7 07/01/19, 16:53
Thanks, Oli for the update! -
Daniel Goerz voted on patch set 7 V +1 CR +1 07/05/19, 15:49
-
Andreas Kienast voted on patch set 7 V +2 CR +2 07/05/19, 16:41
-
Andreas Kienast merged patch set 8 07/05/19, 16:41
Deprecation-88567-_GLOBALSLOCAL_LANG.rst:4Unresolved