Review main Merged

60879[BUGFIX] Ensure "0" is treated as proper fallback in site language

Benni Mack CR +2 V +2 Normal +58 −2 updated 06/07/19, 09:00

Commit message

Due to incomplete handling of "0" and casting, the fallback
is always "0" which is wrong.

The patch fixes the behavior and adds tests to all use-cases
mentioned in the ticket.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 06/05/19, 07:34

  2. TYPO3com voted on patch set 1 V +1 06/05/19, 07:48 Completed build in 14m 32s on Wed, 5 Jun, 09:48 AM Test Summary: 46518 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34188

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 06/05/19, 18:43

  4. Tobi Kretschmann voted on patch set 1 CR +1 06/06/19, 19:38

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 06/07/19, 09:00

  6. Andreas Kienast merged patch set 2 06/07/19, 09:00