Review main Merged

60885[BUGFIX] Change comparison in BasicFileUtility

Georg Ringer CR +2 V +2 Easy +1 −1 updated 07/01/19, 19:52

Commit message

Due to an unrelated change within #76257,
BasicFileUtility never accounts for proper
creating a randomly unique name.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 06/06/19, 03:22

  2. Georg Ringer commented on patch set 1 06/06/19, 03:22

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 06/06/19, 03:38 Completed build in 15m 46s on Thu, 6 Jun, 05:38 AM Test Summary: 46494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34213

  4. Benni Mack updated the commit message in patch set 2 06/11/19, 04:40

  5. Andreas Kienast updated the commit message in patch set 3 06/11/19, 06:27

  6. Andreas Kienast voted on patch set 3 CR +1 06/11/19, 06:29

  7. Benni Mack voted on patch set 3 V +1 CR +1 06/14/19, 19:45

  8. TYPO3com voted on patch set 3 V +1 06/14/19, 20:22 Completed build in 32m 19s on Fri, 14 Jun, 10:22 PM Test Summary: 46486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34356

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 07/01/19, 19:52

  10. Daniel Goerz merged patch set 4 07/01/19, 19:52