Review main Merged Breaking

60886[!!!][TASK] Drop image support in RTE handling

Benni Mack CR +2 V +2 Hard +97 −782 updated 06/12/19, 04:46

Commit message

With the introduction of CKEditor in TYPO3 v8, the support
for images in RTEs is dropped, however functionality was kept
for compatibility with RTEHtmlArea, which was still available in TYPO3 v8
as separate extension.

The functionality to handle images in CKEditor is possible to
be applied again, however, as this cannot be managed properly
via FAL in its current state, the previous functionality is remvoed
from Core. Separate CKEditor extensions as already published,
are able to manage the image handling in CKEditor directly already.

Dropped
* setting TYPO3_CONF_VARS[BE][RTE_imageStorageDir]
* transformation setting "ts_images".
* softref "images" logic
* ImportExport->getRTEoriginalFilename()
* RteHtmlParser->TS_images_rte()
* CLI Command: cleanup:rteimages and Class RteImagesCommand

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 812

  1. Benni Mack uploaded patch set 1 06/06/19, 05:02

  2. TYPO3com voted on patch set 1 V +1 06/06/19, 05:17 Completed build in 14m 09s on Thu, 6 Jun, 07:17 AM Test Summary: 46494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34215

  3. Benni Mack uploaded patch set 2 06/06/19, 05:34

  4. TYPO3com voted on patch set 2 V +1 06/06/19, 05:46 Completed build in 11m 22s on Thu, 6 Jun, 07:46 AM Test Summary: 46492 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34217

  5. Benni Mack uploaded patch set 3 06/08/19, 19:39

  6. TYPO3com voted on patch set 3 V +1 06/08/19, 19:53 Completed build in 13m 59s on Sat, 8 Jun, 09:53 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34277

  7. Andreas Kienast updated the commit message in patch set 4 06/09/19, 13:59

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 06/09/19, 14:00

  9. TYPO3com voted on patch set 4 V +1 06/09/19, 14:09 Completed build in 09m 11s on Sun, 9 Jun, 04:09 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34283

  10. Daniel Gorges voted on patch set 4 V +1 CR +1 06/12/19, 04:29

  11. Benni Mack voted on patch set 4 V +2 CR +2 06/12/19, 04:46

  12. Benni Mack merged patch set 5 06/12/19, 04:46