Review main Merged

60889[FEATURE] Add email address to installation process

Benni Mack CR +2 V +2 Normal +52 −4 updated 09/24/19, 09:36

Commit message

New installations now ask for the email address as well, so
this can be used later on to e.g. notify the admin if somebody
logged-in (Warning email address).

The same feature is available in the maintenance module of
the Install Tool in the "Create Administrative User" card.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2128

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 06/06/19, 05:58

  2. TYPO3com voted on patch set 1 V +1 06/06/19, 06:11 Completed build in 13m 07s on Thu, 6 Jun, 08:11 AM Test Summary: 46494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34221

  3. Georg Ringer commented on patch set 1 06/06/19, 09:18

    ShowDatabaseData.html:33

    type="email" would be nice
  1. Guido Schmechel commented on patch set 1 06/07/19, 09:36

    somebody? ;-)
  2. Oliver Klee commented on patch set 1 06/07/19, 11:04

    Reply Unresolved

    Done

    ShowDatabaseData.html:33 Reply

    Done
  3. Frank Nägler commented on patch set 1 09/23/19, 12:17

    ShowDatabaseData.html:33 Reply Unresolved

    > Done hmm, sure? Where? When? Else I will take over the patch
  4. Frank Nägler commented on patch set 1 CR -1 09/23/19, 12:27

    on it
  5. Frank Nägler uploaded patch set 2 09/23/19, 12:39

  6. Frank Nägler voted on patch set 2 V +1 CR +1 09/23/19, 12:40

  7. Frank Nägler uploaded patch set 3 09/23/19, 12:42

  8. Frank Nägler voted on patch set 3 V +1 CR +1 09/23/19, 12:42

  9. Andreas Kienast commented on patch set 3 09/23/19, 12:50

    Is this also relevant when adding new backend users in the Install Tool?
  10. Frank Nägler commented on patch set 3 V 0 CR -1 09/23/19, 12:56

    > Patch Set 3: > > Is this also relevant when adding new backend users in the Install Tool? a good idea, I will update the patch.
  11. TYPO3com voted on patch set 3 V +1 09/23/19, 13:03 Completed build in 13m 00s on Mon, 23 Sep, 01:03 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36674

  12. Frank Nägler uploaded patch set 4 09/23/19, 13:13

  13. Frank Nägler voted on patch set 4 V +1 CR +1 09/23/19, 13:14

  14. TYPO3com voted on patch set 4 V -1 09/23/19, 13:25 Completed build in 11m 44s on Mon, 23 Sep, 01:25 PM Test Summary: 1 of 48098 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36678

  15. TYPO3com voted on patch set 4 V +1 09/23/19, 13:38 Completed build in 36m 15s on Mon, 23 Sep, 01:38 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36678

  16. Georg Ringer commented on patch set 4 09/23/19, 13:44

    Feature-89227-AskForEmailAddressWhileInstallingTYPO3.rst:13 Unresolved

    I would remove that sentenence, quite confusing as it looks this wasn't done before...

    Feature-89227-AskForEmailAddressWhileInstallingTYPO3.rst:15 Unresolved

    remove that too

    Feature-89227-AskForEmailAddressWhileInstallingTYPO3.rst:18 Unresolved

    so how do we call it now, administration area? if install tool, then please Install Tool
  17. Björn Jacob updated the commit message in patch set 5 09/23/19, 20:18

  18. TYPO3com voted on patch set 5 V +1 09/23/19, 20:27 Completed build in 08m 59s on Mon, 23 Sep, 08:27 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36709

  19. Benni Mack commented on patch set 5 09/24/19, 07:28

    CreateAdmin.ts:97 Unresolved

    looks like we need to reset the email address as well.

    CreateAdmin.html:45 Unresolved

    needs proper prefix as the others
  20. Benni Mack uploaded patch set 6 09/24/19, 07:28

  21. TYPO3com voted on patch set 6 V -1 09/24/19, 07:39 Completed build in 10m 40s on Tue, 24 Sep, 07:39 AM Test Summary: 47531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36717

  22. TYPO3com voted on patch set 6 V +1 09/24/19, 07:48 Completed build in 30m 01s on Tue, 24 Sep, 07:48 AM Test Summary: 47782 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36717

  23. Anja Leichsenring voted on patch set 6 V +1 CR +1 09/24/19, 09:09

  24. Frank Nägler voted on patch set 6 V +2 CR +2 09/24/19, 09:35

  25. Frank Nägler merged patch set 7 09/24/19, 09:36