Review main Merged

60890[BUGFIX] Ensure FormEngine IRRE handles relations in workspace

Benni Mack CR +2 V +2 Easy +45 −2 updated 10/15/19, 10:33

Commit message

FormEngine does not show and handle IRRE records when they are
deleted (connected records from the live workspace are shown).

When removal and refactoring of code in this ares was done for
v9, "too much" code got removed. Which is why workspace overlays
are not handled properly anymore.

In addition, the ElementInformationController now correctly
resolves a workspace record when finding the pageInfo and access.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Achim Fritz +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 2234

Show 69 earlier messages
  1. Benni Mack uploaded patch set 1 06/06/19, 06:44

  2. TYPO3com voted on patch set 1 V +1 06/06/19, 06:58 Completed build in 13m 20s on Thu, 6 Jun, 08:58 AM Test Summary: 46494 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34222

  3. Oliver Hader commented on patch set 1 06/06/19, 07:20

    TcaInline.php:143 Unresolved

    Just guessing... but looks like this one should process version overlays as well
  4. Oliver Klee commented on patch set 1 06/06/19, 08:02

    Should we cover this with regression tests?
  5. Benni Mack wrote 06/28/19, 14:10

    Topic set to workspaces
  6. Achim Fritz uploaded patch set 2 09/17/19, 12:42

  7. TYPO3com voted on patch set 2 V -1 09/17/19, 12:42 Completed build in 11s on Tue, 17 Sep, 12:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36511

  8. Achim Fritz uploaded patch set 3 09/17/19, 13:00

  9. TYPO3com voted on patch set 3 V -1 09/17/19, 13:10 Completed build in 09m 48s on Tue, 17 Sep, 01:10 PM Test Summary: 13 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36513

  1. Achim Fritz uploaded patch set 4 09/17/19, 13:23

  2. TYPO3com voted on patch set 4 V -1 09/17/19, 13:33 Completed build in 10m 20s on Tue, 17 Sep, 01:33 PM Test Summary: 1 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36515

  3. Achim Fritz uploaded patch set 5 09/17/19, 14:32

  4. TYPO3com voted on patch set 5 V -1 09/17/19, 14:42 Completed build in 09m 54s on Tue, 17 Sep, 02:42 PM Test Summary: 47305 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36518

  5. TYPO3com voted on patch set 5 V +1 09/17/19, 14:49 Completed build in 27m 25s on Tue, 17 Sep, 02:49 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36518

  6. Benni Mack uploaded patch set 6 09/17/19, 14:55

  7. Benni Mack voted on patch set 6 CR +1 09/17/19, 14:55

  8. TYPO3com voted on patch set 6 V -1 09/17/19, 15:04 Completed build in 09m 11s on Tue, 17 Sep, 03:04 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36519

  9. TYPO3com voted on patch set 6 V +1 09/17/19, 15:09 Completed build in 23m 05s on Tue, 17 Sep, 03:09 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36519

  10. Daniel Goerz updated the commit message in patch set 7 09/18/19, 10:19

  11. Daniel Goerz commented on patch set 7 09/18/19, 10:20

    ElementInformationController.php:175 Unresolved

    !empty($this->row['t3ver_oid']) should do exactly the same, right?
  12. TYPO3com voted on patch set 7 V -1 09/18/19, 10:30 Completed build in 10m 25s on Wed, 18 Sep, 10:30 AM Test Summary: 1 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36536

  13. Benni Mack uploaded patch set 8 09/18/19, 16:31

  14. Benni Mack uploaded patch set 9 09/18/19, 16:32

  15. TYPO3com voted on patch set 8 V -1 09/18/19, 16:42 Completed build in 11m 20s on Wed, 18 Sep, 04:42 PM Test Summary: 1 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36560

  16. TYPO3com voted on patch set 8 V +1 09/18/19, 16:44 Completed build in 24m 28s on Wed, 18 Sep, 04:44 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36560

  17. TYPO3com voted on patch set 9 V +1 09/18/19, 16:46 Completed build in 11m 06s on Wed, 18 Sep, 04:46 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36561

  18. Daniel Goerz voted on patch set 9 V +1 CR +1 09/18/19, 17:10

  19. Achim Fritz voted on patch set 9 CR +1 09/19/19, 04:56

  20. Benni Mack commented on patch set 9 09/19/19, 07:22

    > Patch Set 1: > > Should we cover this with regression tests? FormEngine is hard to tackle (only good solution currently is acceptance tests), as this EXT:styleguide example we're currently using for acceptance tests does not support versioning. I'm planning on adding versioning to all TCA tables for styleguide, but we'll leave that to a bigger / separate task
  21. Achim Fritz voted on patch set 9 V +1 09/19/19, 07:38

  22. Daniel Goerz voted on patch set 9 V +2 CR +2 09/19/19, 08:04

  23. Daniel Goerz merged patch set 10 09/19/19, 08:04

  24. Oliver Hader voted on patch set 10 CR +1 09/19/19, 19:05

  25. Benni Mack wrote 10/15/19, 10:33

    Created a revert of this change as I02fc745f6171bb6e1170186a6b17a0dfc4fb62e8