Review main Merged

60891[TASK] Use correct TCA for nav_hide and content_from_pid fiels of pages

Markus Klein CR +2 V +2 Easy +21 −17 updated 08/02/19, 09:47

Commit message

'l10n_mode' => 'prefixLangTitle'
does not make sense for checkboxes and group types

Add language sync to those fields, so those can be overwritten in
translations.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1117

  1. Markus Klein uploaded patch set 1 06/06/19, 16:01

  2. Oliver Hader voted on patch set 1 CR +1 06/06/19, 16:08

  3. TYPO3com voted on patch set 1 V -1 06/06/19, 16:14 Completed build in 12m 50s on Thu, 6 Jun, 06:14 PM Test Summary: 24 of 46833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34227

  4. Markus Klein commented on patch set 1 CR -1 06/06/19, 16:22

    Args... I need to fix all those tests too.
  5. Markus Klein uploaded patch set 2 06/22/19, 09:57

  6. TYPO3com voted on patch set 2 V -1 06/22/19, 10:06 Completed build in 09m 32s on Sat, 22 Jun, 12:06 PM Test Summary: 24 of 46829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34510

  7. Markus Klein rebased onto patch set 3 08/01/19, 11:00

  8. Markus Klein uploaded patch set 4 08/01/19, 11:11

  9. TYPO3com voted on patch set 3 V -1 08/01/19, 11:11 Completed build in 11m 37s on Thu, 1 Aug, 11:11 AM Test Summary: 24 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35427

  10. TYPO3com voted on patch set 4 V +1 08/01/19, 11:21 Completed build in 10m 06s on Thu, 1 Aug, 11:21 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35428

  11. Markus Klein uploaded patch set 5 08/01/19, 11:23

  12. Markus Klein uploaded patch set 6 08/01/19, 11:25

  13. TYPO3com voted on patch set 5 V -1 08/01/19, 11:36 Completed build in 12m 55s on Thu, 1 Aug, 11:36 AM Test Summary: 24 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35429

  14. TYPO3com voted on patch set 6 V +1 08/01/19, 11:38 Completed build in 13m 17s on Thu, 1 Aug, 11:38 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35430

  15. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/02/19, 09:46

  16. Georg Ringer voted on patch set 6 V +2 CR +2 08/02/19, 09:47

  17. Georg Ringer merged patch set 7 08/02/19, 09:47