60893[WIP][POC][!!!][TASK] Drop ObjectStorage in favor of doctrine/collections collection
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 31
- typo3/sysext/beuser/Classes/Domain/Model/BackendUser.php2+4 −2
- typo3/sysext/beuser/Classes/Domain/Model/BackendUserGroup.php+6 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Content.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Hotel.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Domain/Model/Offer.php+1 −1
- typo3/sysext/extbase/Classes/Domain/Model/BackendUserGroup.php+10 −9
- typo3/sysext/extbase/Classes/Domain/Model/FrontendUser.php+15 −12
- typo3/sysext/extbase/Classes/Domain/Model/FrontendUserGroup.php+10 −7
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+52 −25
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+40 −36
- typo3/sysext/extbase/Classes/Persistence/Generic/BackendInterface.php+8 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+13 −13
- typo3/sysext/extbase/Classes/Persistence/Generic/Session.php+8 −8
- typo3/sysext/extbase/Classes/Persistence/ORM/PersistentCollection.phpnew+294 −0
- typo3/sysext/extbase/Classes/Persistence/ORM/UnitOfWork.phpnew+74 −0
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+1 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php+8 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+13 −11
- typo3/sysext/extbase/Classes/Utility/TypeHandlingUtility.php+3 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+2 −2
Show 11 more files
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Person.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/TtContent.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Domain/Model/BackendUserGroupTest.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Domain/Model/FrontendUserGroupTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Domain/Model/FrontendUserTest.php+8 −6
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+9 −9
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+3 −3
- composer.json+1 −0
- composer.lock+71 −68
Review log 910
-
Alexander Schnitzler uploaded patch set 1 06/06/19, 19:31
-
TYPO3com voted on patch set 1 V -1 06/06/19, 19:42 Completed build in 11m 00s on Thu, 6 Jun, 09:42 PM Test Summary: 152 of 46833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34231
-
Mathias Brodala commented on patch set 1 06/07/19, 07:18
I know its WIP and POC but I'd like to raise my concern early. Also we should consider to keep ObjectStorage alive at least for v10, otherwise life of 3rd party extension authors will get harder. They'll need to maintain two different code bases for v10 and older or do some hacks.BackendUser.php:17I really dislike that it is impossible to see that this is actually "CollectionInterface" so I'd suggest to always do this: use Doctrine\Common\Collections\Collection as CollectionInterface Also see https://www.php-fig.org/bylaws/psr-naming-conventions/ -
Alexander Schnitzler commented on patch set 1 06/10/19, 10:04
> I know its WIP and POC but I'd like to raise my concern early. > > Also we should consider to keep ObjectStorage alive at least for v10, otherwise life of 3rd party extension authors will get harder. They'll need to maintain two different code bases for v10 and older or do some hacks. Don't worry. If this patch makes it into 10.x, ObjectStorage will still be supported as an extension of the PersistentCollection class to keep the current api intact. Also, The ObjectStorage annotation in models still works with this patch. Actually, every foo<bar> annotation will result in the detection of a collection. Even in version 9 that's the case, we only assume that we use an ObjectStorage class here and nothing else. So, I see your concerns and I strive to be as non breaking as possible, period. :) -
Alexander Schnitzler commented on patch set 1 06/10/19, 10:05
BackendUser.php:17Reply UnresolvedThat's a good idea! Will be changed in the next patch set. -
Alexander Schnitzler marked it work in progress 06/20/19, 11:37
-
Benni Mack wrote 11/29/21, 10:02
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:15
-
Christian Kuhn commented on patch set 2 09/26/22, 10:54
Hey. I hope it's ok to abandon here for now: The patch stalled for 3 years now without anyone working on it. I see the possible benefit of it and we can very well discuss the topic again in case anyone is willing to pick it up again. -
Christian Kuhn abandoned the change 09/26/22, 10:54