Review main Merged

60895[BUGFIX] Ignore cHash when given but not needed

Benni Mack CR +2 V +2 Normal +121 −4 updated 06/08/19, 04:07

Commit message

If a cHash GET parameter is given, but there
are no GET parameters that are relevant, a
hash_calc() call against an empty string is done.

However, the change now allows an invalid
cHash if no check is necessary. This could
happen when upgrading from older instances
where a cHash is not needed anymore.

Bots would not then fill up the error log
but get the new page (with a valid 200 result)

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Benni Mack uploaded patch set 1 06/07/19, 07:31

  2. Mathias Brodala commented on patch set 1 06/07/19, 07:34

    PageArgumentValidatorTest.php:72 Unresolved

    Micro-nitpick: this should be example.org or similar. ;-)
  3. TYPO3com voted on patch set 1 V +1 06/07/19, 07:44 Completed build in 13m 18s on Fri, 7 Jun, 09:44 AM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34235

  4. Benni Mack uploaded patch set 2 06/07/19, 08:00

  5. TYPO3com voted on patch set 2 V +1 06/07/19, 08:13 Completed build in 12m 55s on Fri, 7 Jun, 10:13 AM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34236

  6. Andreas Kienast commented on patch set 2 CR -1 06/07/19, 08:18

    PageArgumentValidator.php:121 Unresolved

    $calcatedCacheHash != $calc*u*latedCacheHash
  7. Andreas Kienast uploaded patch set 3 06/07/19, 08:19

  8. Andreas Kienast uploaded patch set 4 06/07/19, 08:26

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 06/07/19, 08:26

  10. TYPO3com voted on patch set 3 V +1 06/07/19, 08:34 Completed build in 14m 56s on Fri, 7 Jun, 10:34 AM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34237

  11. TYPO3com voted on patch set 4 V +1 06/07/19, 08:41 Completed build in 14m 25s on Fri, 7 Jun, 10:41 AM Test Summary: 46502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34238

  12. Georg Ringer voted on patch set 4 V +2 CR +2 06/08/19, 04:07

  13. Georg Ringer merged patch set 5 06/08/19, 04:07