Review 9.5 Merged

60896[BUGFIX] Ensure "0" is treated as proper fallback in site language

Andreas Kienast CR +2 V +2 Normal +58 −2 updated 06/07/19, 09:15

Commit message

Due to incomplete handling of "0" and casting, the fallback
is always "0" which is wrong.

The patch fixes the behavior and adds tests to all use-cases
mentioned in the ticket.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 06/07/19, 09:00

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/07/19, 09:14 Completed build in 13m 49s on Fri, 7 Jun, 11:14 AM Test Summary: 50393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-766

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 06/07/19, 09:15

  4. Andreas Kienast merged patch set 2 06/07/19, 09:15