60897[TASK] Install Tool: Move common code into abstract class
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Simon Gilli +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Jonas Eberle +1
- TYPO3com +1 CI
Issues 1
Files 54
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/AbstractInteractableModule.ts3new+32 −0
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ChangeInstallToolPassword.ts+8 −11
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ClearTables.ts+5 −8
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ClearTypo3tempFiles.ts+5 −8
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/CoreUpdate.ts+8 −11
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/CreateAdmin.ts+13 −16
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/DatabaseAnalyzer.ts+6 −9
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/EnvironmentCheck.ts+3 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ExtensionCompatTester.ts+12 −15
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ExtensionConfiguration.ts+7 −10
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ExtensionScanner.ts+17 −20
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Features.ts+6 −9
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/FolderStructure.ts+5 −7
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/ImageProcessing.ts+5 −7
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/InteractableModuleInterface.tsdeleted+0 −16
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/LanguagePacks.ts+21 −25
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/LocalConfiguration.ts+7 −10
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/MailTest.ts+6 −9
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/PhpInfo.ts+3 −6
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Presets.ts+9 −12
Show 34 more files
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/SystemInformation.ts+3 −6
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/SystemMaintainer.ts+6 −9
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/TcaExtTablesCheck.ts+3 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/TcaMigrationsCheck.ts+3 −5
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/UpgradeDocs.ts+18 −21
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/UpgradeWizards.ts+25 −27
- Build/Sources/TypeScript/install/Resources/Public/TypeScript/Router.ts+2 −2
- typo3/sysext/install/Resources/Private/Templates/Settings/FeaturesGetContent.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Settings/PresetsGetContent.html+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/AbstractInteractableModule.jsnew+13 −0
- typo3/sysext/install/Resources/Public/JavaScript/Module/ChangeInstallToolPassword.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ClearTables.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ClearTypo3tempFiles.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/CoreUpdate.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/CreateAdmin.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/DatabaseAnalyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/EnvironmentCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ExtensionCompatTester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ExtensionConfiguration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ExtensionScanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Features.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/FolderStructure.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/ImageProcessing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/LanguagePacks.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/LocalConfiguration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/MailTest.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/PhpInfo.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/Presets.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/SystemInformation.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/SystemMaintainer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/TcaExtTablesCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/TcaMigrationsCheck.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/UpgradeDocs.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/Module/UpgradeWizards.js+1 −1
Review log 1522
-
Andreas Kienast uploaded patch set 1 06/07/19, 11:55
-
Andreas Kienast uploaded patch set 2 06/07/19, 12:01
-
Andreas Kienast uploaded patch set 3 06/07/19, 12:08
-
TYPO3com voted on patch set 2 V -1 06/07/19, 12:15 Completed build in 14m 23s on Fri, 7 Jun, 02:15 PM Test Summary: 46548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34244
-
Andreas Kienast uploaded patch set 4 06/07/19, 12:18
-
TYPO3com voted on patch set 3 V +1 06/07/19, 12:22 Completed build in 14m 34s on Fri, 7 Jun, 02:22 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34245
-
TYPO3com voted on patch set 4 V +1 06/07/19, 12:32 Completed build in 13m 33s on Fri, 7 Jun, 02:32 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34247
-
Andreas Kienast uploaded patch set 5 06/07/19, 13:03
-
Andreas Kienast uploaded patch set 6 06/07/19, 13:03
-
Andreas Kienast uploaded patch set 7 06/07/19, 13:16
-
TYPO3com commented on patch set 5 06/07/19, 13:18 Completed build in 15m 26s on Fri, 7 Jun, 03:18 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34248
-
TYPO3com voted on patch set 6 V +1 06/07/19, 13:20 Completed build in 16m 27s on Fri, 7 Jun, 03:20 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34249
-
TYPO3com voted on patch set 7 V +1 06/07/19, 13:29 Completed build in 13m 32s on Fri, 7 Jun, 03:29 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34250
-
Jonas Eberle voted on patch set 7 V +1 06/07/19, 14:10
-
Andreas Kienast uploaded patch set 8 06/09/19, 14:11
-
TYPO3com voted on patch set 8 V +1 06/09/19, 14:25 Completed build in 13m 33s on Sun, 9 Jun, 04:25 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34284
-
Simon Gilli commented on patch set 8 06/09/19, 20:54
-
Andreas Kienast commented on patch set 8 06/09/19, 21:03
AbstractInteractableModule.ts:14ReplyNothing in the Install Tool is considered being public API, so there is no breaking change. In either way, the interface was introduced a few weeks ago, so it never made it into a release. -
Simon Gilli commented on patch set 8 CR +1 06/10/19, 10:13
AbstractInteractableModule.ts:14ReplyAck -
Jonas Eberle voted on patch set 8 V +1 06/11/19, 09:56
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 06/18/19, 18:42
-
Anja Leichsenring merged patch set 9 06/18/19, 18:42
AbstractInteractableModule.ts:14