Review main Merged

60897[TASK] Install Tool: Move common code into abstract class

Andreas Kienast CR +2 V +2 Hard +277 −315 updated 06/18/19, 18:42

Commit message

All modules of the Install Tool used in modal windows now share a common
abstract class that contains some boilerplate code required for most
modules.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 54

Show 34 more files

Review log 1522

  1. Andreas Kienast uploaded patch set 1 06/07/19, 11:55

  2. Andreas Kienast uploaded patch set 2 06/07/19, 12:01

  3. Andreas Kienast uploaded patch set 3 06/07/19, 12:08

  4. TYPO3com voted on patch set 2 V -1 06/07/19, 12:15 Completed build in 14m 23s on Fri, 7 Jun, 02:15 PM Test Summary: 46548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34244

  5. Andreas Kienast uploaded patch set 4 06/07/19, 12:18

  6. TYPO3com voted on patch set 3 V +1 06/07/19, 12:22 Completed build in 14m 34s on Fri, 7 Jun, 02:22 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34245

  7. TYPO3com voted on patch set 4 V +1 06/07/19, 12:32 Completed build in 13m 33s on Fri, 7 Jun, 02:32 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34247

  8. Andreas Kienast uploaded patch set 5 06/07/19, 13:03

  9. Andreas Kienast uploaded patch set 6 06/07/19, 13:03

  10. Andreas Kienast uploaded patch set 7 06/07/19, 13:16

  11. TYPO3com commented on patch set 5 06/07/19, 13:18 Completed build in 15m 26s on Fri, 7 Jun, 03:18 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34248

  12. TYPO3com voted on patch set 6 V +1 06/07/19, 13:20 Completed build in 16m 27s on Fri, 7 Jun, 03:20 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34249

  13. TYPO3com voted on patch set 7 V +1 06/07/19, 13:29 Completed build in 13m 32s on Fri, 7 Jun, 03:29 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34250

  14. Jonas Eberle voted on patch set 7 V +1 06/07/19, 14:10

  15. Andreas Kienast uploaded patch set 8 06/09/19, 14:11

  16. TYPO3com voted on patch set 8 V +1 06/09/19, 14:25 Completed build in 13m 33s on Sun, 9 Jun, 04:25 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34284

  17. Simon Gilli commented on patch set 8 06/09/19, 20:54

    AbstractInteractableModule.ts:14

    Shouldn't this abstract class implement InteractableModuleInterface as the other classes did before to not to be breaking?
  18. Andreas Kienast commented on patch set 8 06/09/19, 21:03

    AbstractInteractableModule.ts:14 Reply

    Nothing in the Install Tool is considered being public API, so there is no breaking change. In either way, the interface was introduced a few weeks ago, so it never made it into a release.
  19. Simon Gilli commented on patch set 8 CR +1 06/10/19, 10:13

    AbstractInteractableModule.ts:14 Reply

    Ack
  20. Jonas Eberle voted on patch set 8 V +1 06/11/19, 09:56

  21. Anja Leichsenring voted on patch set 8 V +2 CR +2 06/18/19, 18:42

  22. Anja Leichsenring merged patch set 9 06/18/19, 18:42