Review main Merged

60900[BUGFIX] t3editor: Harden some checks for TS parsing

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 06/14/19, 19:14

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Sven Juergens +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 911

  1. Andreas Kienast uploaded patch set 1 06/07/19, 15:53

  2. Andreas Kienast updated the commit message in patch set 2 06/07/19, 16:04

  3. Andreas Kienast updated the commit message in patch set 3 06/07/19, 16:04

  4. TYPO3com voted on patch set 1 V +1 06/07/19, 16:09 Completed build in 16m 33s on Fri, 7 Jun, 06:09 PM Test Summary: 46549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34256

  5. TYPO3com voted on patch set 3 V +1 06/07/19, 16:32 Completed build in 22m 19s on Fri, 7 Jun, 06:32 PM Test Summary: 46550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34261

  6. Riccardo De Contardi commented on patch set 3 V +1 06/07/19, 19:05

    The patch fixes both the cases described on https://forge.typo3.org/issues/85346 and https://forge.typo3.org/issues/88262
  7. Sven Juergens voted on patch set 3 V +1 CR +1 06/11/19, 12:18

  8. Sven Juergens wrote 06/11/19, 12:18

    Removed Code-Review+1 by Sven Juergens <typo3@blue-side.de>
  9. Georg Ringer voted on patch set 3 V +1 CR +1 06/12/19, 06:02

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 06/14/19, 19:13

  11. Andreas Kienast merged patch set 4 06/14/19, 19:14