60903[BUGFIX] Tests broken with phpunit 8.2
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Andreas Kienast +1
-
Verified V +2 Done
- Susi Moog +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Tests/Unit/Log/Writer/AbstractWriterTest.php1+2 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+10 −9
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/ViewHelperResolverTest.php+8 −10
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetRequestHandlerTest.php+5 −4
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+21 −35
- typo3/sysext/form/Tests/Unit/Domain/Configuration/ConfigurationServiceTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionValidationServiceTest.php+7 −6
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.php+3 −9
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+16 −31
- typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+7 −28
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php1+2 −2
- typo3/sysext/seo/Tests/Unit/XmlSitemap/PagesXmlSitemapDataProviderTest.php1+2 −1
Review log 911
-
Anja Leichsenring uploaded patch set 1 06/08/19, 09:43
-
TYPO3com voted on patch set 1 V +1 06/08/19, 10:00 Completed build in 17m 12s on Sat, 8 Jun, 12:00 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34274
-
Andreas Kienast voted on patch set 1 V +1 CR +1 06/08/19, 19:07
-
Anja Leichsenring commented on patch set 1 06/09/19, 19:21
the 9.5 merge has to wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/60777 is in. -
Susi Moog commented on patch set 1 06/11/19, 06:46
AbstractWriterTest.php:37Unresolvedhm, but this now also opens a log in construct - are we sure that is side-effect free?FrontendUserAuthenticationTest.php:378Unresolved"return" missing.PagesXmlSitemapDataProviderTest.php:67Unresolvedlet's find out before merging ;) -
Susi Moog uploaded patch set 2 06/11/19, 07:22
-
TYPO3com voted on patch set 2 V +1 06/11/19, 07:42 Completed build in 15m 46s on Tue, 11 Jun, 09:42 AM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34288
-
Andreas Kienast voted on patch set 2 V +1 CR +1 06/11/19, 09:16
-
Susi Moog voted on patch set 2 V +2 CR +2 06/11/19, 11:30
-
Susi Moog merged patch set 3 06/11/19, 11:32
-
Anja Leichsenring commented on patch set 3 06/12/19, 07:37
no backport, because v9 will not be updated to use phpunit v8.