Review main Merged

60903[BUGFIX] Tests broken with phpunit 8.2

Anja Leichsenring CR +2 V +2 Normal +89 −142 updated 06/12/19, 07:37

Commit message

Switching from accessibleMock to prophecy resolves
a lot of failures.
Also, using a concrete instance instead accessibleMockForAbstractClass
reduces issues.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 911

  1. Anja Leichsenring uploaded patch set 1 06/08/19, 09:43

  2. TYPO3com voted on patch set 1 V +1 06/08/19, 10:00 Completed build in 17m 12s on Sat, 8 Jun, 12:00 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34274

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 06/08/19, 19:07

  4. Anja Leichsenring commented on patch set 1 06/09/19, 19:21

    the 9.5 merge has to wait until https://review.typo3.org/c/Packages/TYPO3.CMS/+/60777 is in.
  5. Susi Moog commented on patch set 1 06/11/19, 06:46

    AbstractWriterTest.php:37 Unresolved

    hm, but this now also opens a log in construct - are we sure that is side-effect free?

    FrontendUserAuthenticationTest.php:378 Unresolved

    "return" missing.

    PagesXmlSitemapDataProviderTest.php:67 Unresolved

    let's find out before merging ;)
  6. Susi Moog uploaded patch set 2 06/11/19, 07:22

  7. TYPO3com voted on patch set 2 V +1 06/11/19, 07:42 Completed build in 15m 46s on Tue, 11 Jun, 09:42 AM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34288

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 06/11/19, 09:16

  9. Susi Moog voted on patch set 2 V +2 CR +2 06/11/19, 11:30

  10. Susi Moog merged patch set 3 06/11/19, 11:32

  11. Anja Leichsenring commented on patch set 3 06/12/19, 07:37

    no backport, because v9 will not be updated to use phpunit v8.