60904[!!!][TASK] Plugin configuration does not restrict access to actions
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 34
- typo3/sysext/belog/ext_tables.php+1 −1
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+1 −1
- typo3/sysext/beuser/ext_tables.php+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88529-ControllerActionsNeedToBePublic.rstnew+32 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-88529-PluginAndModuleConfigurationsDoNoLongerDetermineAllowedActions.rst2new+52 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/ext_localconf.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Web/RequestBuilder.php+16 −9
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+78 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php+8 −56
- typo3/sysext/extbase/Tests/Unit/Utility/Fixtures/MyExtension/Controller/FirstController.php+21 −0
- typo3/sysext/extbase/Tests/Unit/Utility/Fixtures/MyExtension/Controller/SecondController.php+9 −0
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+172 −15
- typo3/sysext/extbase/Tests/UnitDeprecated/Utility/ExtensionUtilityTest.php+9 −9
- typo3/sysext/extbase/composer.json+5 −2
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+4 −4
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+2 −2
- typo3/sysext/extensionmanager/ext_tables.php+4 −4
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −3
Show 14 more files
- typo3/sysext/filelist/ext_tables.php+1 −1
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+1 −3
- typo3/sysext/form/ext_localconf.php+1 −1
- typo3/sysext/form/ext_tables.php+2 −2
- typo3/sysext/indexed_search/ext_localconf.php+1 −1
- typo3/sysext/indexed_search/ext_tables.php+1 −1
- typo3/sysext/install/Classes/Controller/UpgradeController.php+5 −0
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/NonPublicControllerActionMethodMatcher.phpnew+102 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassMethodMatcher.phpnew+8 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+2 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/NonPublicControllerActionMethodMatcherFixture.phpnew+52 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/NonPublicControllerActionMethodMatcherTest.phpnew+61 −0
- typo3/sysext/workspaces/ext_tables.php+1 −1
- composer.json+2 −1
Review log 1114
-
Alexander Schnitzler uploaded patch set 1 06/08/19, 11:38
-
TYPO3com voted on patch set 1 V -1 06/08/19, 11:52 Completed build in 13m 07s on Sat, 8 Jun, 01:52 PM Test Summary: 15 of 46897 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34275
-
Alexander Schnitzler uploaded patch set 2 06/08/19, 19:49
-
TYPO3com voted on patch set 2 V -1 06/08/19, 19:59 Completed build in 09m 46s on Sat, 8 Jun, 09:59 PM Test Summary: 84 of 46893 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34278
-
Alexander Schnitzler uploaded patch set 3 06/09/19, 07:49
-
TYPO3com voted on patch set 3 V +1 06/09/19, 09:39 Completed build in 11m 24s on Sun, 9 Jun, 11:39 AM Test Summary: 46554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34279
-
Alexander Schnitzler commented on patch set 3 CR -2 06/09/19, 09:50
Still WIP. -
Alexander Schnitzler marked it work in progress 07/01/19, 15:39
-
Stephan Großberndt commented on patch set 3 07/12/19, 11:05
First off: Thank you Alex for your continuous work on extbase! This is a *very* breaking change forcing extension authors to change their controller layout heavily. Is it really worth to do so? Why are there so many breaking changes introduced for extbase without deprecating like the core usually does?Important-88529-PluginAndModuleConfigurationsDoNoLongerDetermineAllowedActions.rst:29Where is `controllerActions` defined? -
Alexander Schnitzler commented on patch set 3 07/13/19, 10:17
> Patch Set 3: > > (1 comment) > > First off: Thank you Alex for your continuous work on extbase! > > This is a *very* breaking change forcing extension authors to change their controller layout heavily. Is it really worth to do so? I know and it's the main reason this will not make it like this into version 10. The change is actually worth it but I understand that bringing this into core without a deprecation phase will be no benefit for anyone. It's a very good change regarding the achievement of a much cleaner and more predictable code architecture but I will first deprecate this behaviour and I will talk to Benni if we deprecate this until 11.0 or 12.0. Which brings me to you next question and my answer. > Why are there so many breaking changes introduced for extbase without deprecating like the core usually does? At some point we need to be breaking and sometimes we want to be breaking without a deprecation phase. That's not to make the life of developers harder, it's just that every deprecation means 1,5 years of delay for a change. And if changes are important and we didn't have the vision for the change 1,5 years ago, we have no other chance than to introduce breaking changes that have not been announced earlier. Unfortunately TYPO3 isn't developed feature-driven with a clear roadmap. If someone has time to change things, he/she will do so the moment the time is available. Some things are roughly planned but most things evolve around fixed release dates. Looking at Extbase, we see a very stable api since at least version 6.2 because nothing changed. There were hardly any bugfixes or features. I have had a vision to change that for years but I didn't find the energy and the time to get started until about last year ago. All those years people complained that Extbase has its issues and it's true. Now, it's moving to fast is what I hear. This is without blaming anyone. It's just a fact that there is not one best solution for everyone. There is one thing I want to stress here. Every time I have an idea about a change I develop code and I push it as WIP. This is to be fully transparent about what I think about. There is a change regarding symfony/validator for instance which is WIP, had been created months ago and will not make it into the core the next months because there is so much preparatory work to be done before. And this patch is about the same. We communicate that there is an and date for switchable controller actions and there will be this change about the pseudo-protected actions and we mark it as breaking but god knows when this will make it into the core. With version 10.0 to be released soon and the loose promise not to introduce breaking changes afterwards, you're looking at very few breaking changes in the Extbase area actually. Most changes only possibly change the api, even some changes to internal classes have been marked breaking just to be cautious. And then there are 3 or 4 unforeseen breaking changes that are easy to migrate. So, if you spot a change of mine that is marked breaking, feel free to comment early. I hope all questions are answered. If not, please reply again. :) -
Alexander Schnitzler commented on patch set 3 07/13/19, 10:20
Important-88529-PluginAndModuleConfigurationsDoNoLongerDetermineAllowedActions.rst:29Reply Unresolved$controllerActions is the 3rd parameter of configurePlugin and the nth (don't know the exact position) parameter of registerModule. This means, the api of the registration methods doesn't change. -
Benni Mack wrote 11/29/21, 10:01
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 4 11/29/21, 13:15
-
Alexander Schnitzler abandoned the change 03/17/23, 14:28
Lost interest, too blocking obviously.