60905[TASK] Create Redirect instead of silently ignoring superfluous cHash
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Nicole Hummel +1
-
Verified V +2 Done
- Andreas Kienast +2
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 2225
-
Benni Mack uploaded patch set 1 06/08/19, 18:22
-
TYPO3com voted on patch set 1 V +1 06/08/19, 18:35 Completed build in 12m 36s on Sat, 8 Jun, 08:35 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34276
-
Mathias Brodala commented on patch set 1 06/11/19, 07:15
-
Andreas Kienast commented on patch set 1 06/11/19, 07:28
PageArgumentValidator.php:109The page id can be fetched via `$request->getAttribute('routing')->getPageId()`, IMO no need to use TSFE here. -
Andreas Kienast voted on patch set 1 V +1 06/11/19, 07:29
-
Benni Mack commented on patch set 1 06/11/19, 08:28
PageArgumentValidator.php:109Reply Unresolvednope. not for v9 -
Markus Klein commented on patch set 1 06/11/19, 08:47
PageArgumentValidator.php:88Should we make it a 301? -
Nicole Hummel commented on patch set 1 06/11/19, 08:58
PageArgumentValidator.php:113UnresolvedMaybe we can return false in here and check if $this->controller->cHash_array is empty to generate the redirect message. IHMO this would prevent double checking with code changes from above. -
Mathias Brodala commented on patch set 1 06/11/19, 09:13
PageArgumentValidator.php:88ReplyThat would mean POST'ed data is lost upon redirect. -
Markus Klein commented on patch set 1 06/11/19, 10:09
PageArgumentValidator.php:88Reply UnresolvedRight, but then 308 is the correct one. -
Benni Mack uploaded patch set 2 06/12/19, 04:14
-
Andreas Kienast commented on patch set 2 06/12/19, 06:23
PageArgumentValidator.php:91UnresolvedHow likely is it that a given cHash that is not required _now_ will become required at a later point (the exact same cHash)? This wouldn't work anymore with a "308 Permanent Redirect". -
Benni Mack commented on patch set 2 06/12/19, 06:36
Please see the discussion on https://forge.typo3.org/issues/41033 -
Benni Mack updated the commit message in patch set 3 06/12/19, 06:37
-
Nicole Hummel uploaded patch set 4 06/12/19, 10:12
-
Benni Mack updated the commit message in patch set 5 06/12/19, 21:06
-
Benni Mack commented on patch set 5 06/12/19, 21:07
rebase. -
Nicole Hummel voted on patch set 5 V +1 CR +1 06/12/19, 21:13
-
TYPO3com voted on patch set 5 V -1 06/12/19, 21:40 Completed build in 28m 53s on Wed, 12 Jun, 11:40 PM Test Summary: 4 of 46865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34298
-
Benni Mack uploaded patch set 6 06/13/19, 08:32
-
TYPO3com voted on patch set 6 V +1 06/13/19, 08:49 Completed build in 17m 33s on Thu, 13 Jun, 10:49 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34308
-
Andreas Kienast voted on patch set 6 V +1 CR +1 06/13/19, 09:08
-
Nicole Hummel voted on patch set 6 V +1 CR +1 06/14/19, 10:53
-
Andreas Kienast voted on patch set 6 V +2 CR +2 06/14/19, 10:56
-
Andreas Kienast merged patch set 7 06/14/19, 10:56
PageArgumentValidator.php:86Unresolved