Review main Merged

60905[TASK] Create Redirect instead of silently ignoring superfluous cHash

Benni Mack CR +2 V +2 Easy +25 −11 updated 06/14/19, 10:56

Commit message

Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895
cHash's that are used within the URL but not needed
anymore, should rather create a redirect instead
of silently unsetting the cHash argument.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Nicole Hummel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 2225

  1. Benni Mack uploaded patch set 1 06/08/19, 18:22

  2. TYPO3com voted on patch set 1 V +1 06/08/19, 18:35 Completed build in 12m 36s on Sat, 8 Jun, 08:35 PM Test Summary: 46542 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34276

  3. Mathias Brodala commented on patch set 1 06/11/19, 07:15

    PageArgumentValidator.php:86 Unresolved

    We should issue a DEBUG/NOTICE log message here, otherwise this can lead to confusion.
  4. Andreas Kienast commented on patch set 1 06/11/19, 07:28

    PageArgumentValidator.php:109

    The page id can be fetched via `$request->getAttribute('routing')->getPageId()`, IMO no need to use TSFE here.
  5. Andreas Kienast voted on patch set 1 V +1 06/11/19, 07:29

  6. Benni Mack commented on patch set 1 06/11/19, 08:28

    PageArgumentValidator.php:109 Reply Unresolved

    nope. not for v9
  7. Markus Klein commented on patch set 1 06/11/19, 08:47

    PageArgumentValidator.php:88

    Should we make it a 301?
  8. Nicole Hummel commented on patch set 1 06/11/19, 08:58

    PageArgumentValidator.php:113 Unresolved

    Maybe we can return false in here and check if $this->controller->cHash_array is empty to generate the redirect message. IHMO this would prevent double checking with code changes from above.
  9. Mathias Brodala commented on patch set 1 06/11/19, 09:13

    PageArgumentValidator.php:88 Reply

    That would mean POST'ed data is lost upon redirect.
  10. Markus Klein commented on patch set 1 06/11/19, 10:09

    PageArgumentValidator.php:88 Reply Unresolved

    Right, but then 308 is the correct one.
  11. Benni Mack uploaded patch set 2 06/12/19, 04:14

  12. Andreas Kienast commented on patch set 2 06/12/19, 06:23

    PageArgumentValidator.php:91 Unresolved

    How likely is it that a given cHash that is not required _now_ will become required at a later point (the exact same cHash)? This wouldn't work anymore with a "308 Permanent Redirect".
  13. Benni Mack commented on patch set 2 06/12/19, 06:36

    Please see the discussion on https://forge.typo3.org/issues/41033
  14. Benni Mack updated the commit message in patch set 3 06/12/19, 06:37

  15. Nicole Hummel uploaded patch set 4 06/12/19, 10:12

  16. Benni Mack updated the commit message in patch set 5 06/12/19, 21:06

  17. Benni Mack commented on patch set 5 06/12/19, 21:07

    rebase.
  18. Nicole Hummel voted on patch set 5 V +1 CR +1 06/12/19, 21:13

  19. TYPO3com voted on patch set 5 V -1 06/12/19, 21:40 Completed build in 28m 53s on Wed, 12 Jun, 11:40 PM Test Summary: 4 of 46865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34298

  20. Benni Mack uploaded patch set 6 06/13/19, 08:32

  21. TYPO3com voted on patch set 6 V +1 06/13/19, 08:49 Completed build in 17m 33s on Thu, 13 Jun, 10:49 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34308

  22. Andreas Kienast voted on patch set 6 V +1 CR +1 06/13/19, 09:08

  23. Nicole Hummel voted on patch set 6 V +1 CR +1 06/14/19, 10:53

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 06/14/19, 10:56

  25. Andreas Kienast merged patch set 7 06/14/19, 10:56