Review main Merged

60906[BUGFIX] Convert class aliases of switchable controller actions to FQCN's

Alexander Schnitzler CR +2 V +2 Normal +147 −15 updated 06/28/19, 15:14

Commit message

When the patch https://forge.typo3.org/issues/87550 changed the controller
configuration of plugins and modules to use fully qualified controller
class names instead of just controller aliases, the override mechanism
called switchable controller actions, that can be used via typoscript
and flexforms broke.

This is due to the fact that switchable controller actions are usually
still used with controller aliases rather than fully qualified controller
class names.

To fix this, method overrideSwitchableControllerActions of class
\TYPO3\CMS\Extbase\Configuration\AbstractConfigurationManager has been
adjusted to convert controller aliases to FQCN's before overriding the
controller configuration.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 06/09/19, 09:36

  2. TYPO3com voted on patch set 1 V +1 06/09/19, 09:49 Completed build in 13m 19s on Sun, 9 Jun, 11:49 AM Test Summary: 46546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34280

  3. Alexander Schnitzler uploaded patch set 2 06/09/19, 10:02

  4. TYPO3com voted on patch set 2 V +1 06/09/19, 10:15 Completed build in 12m 46s on Sun, 9 Jun, 12:15 PM Test Summary: 46546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34281

  5. Alexander Schnitzler wrote 06/21/19, 15:35

    Topic set to extbase
  6. Benni Mack voted on patch set 2 CR +1 06/28/19, 13:09

  7. Benni Mack voted on patch set 2 V +1 06/28/19, 13:57

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 06/28/19, 15:14

  9. Daniel Goerz merged patch set 3 06/28/19, 15:14