Review 9.5 Merged

60938[BUGFIX] Allow same configuration key in multiple extensions

Benni Mack CR +2 V +2 Easy +29 −13 updated 06/13/19, 10:19

Commit message

Fix two issues in the extension configuration tool if more than one
extension is using the same configuration key:

* Remove duplicate HTML IDs in extension configuration tool
* Correctly add hidden fields with value=0 for checkboxes within every
  sub-<form>, not only on first occurence (first extension) of any given
  configuration key

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Benni Mack uploaded patch set 1 06/12/19, 04:23

  2. Jonas Eberle voted on patch set 1 V +1 06/12/19, 08:24

  3. TYPO3com voted on patch set 1 V +1 06/13/19, 10:04 Completed build in 18m 35s on Thu, 13 Jun, 12:04 PM Test Summary: 50401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-779

  4. Benni Mack voted on patch set 1 V +2 CR +2 06/13/19, 10:19

  5. Benni Mack merged patch set 2 06/13/19, 10:19