Review main Merged Breaking

60939[!!!][TASK] Move Frontend User session saving into Middleware

Benni Mack CR +2 V +2 Normal +68 −3 updated 06/13/19, 09:29

Commit message

For further TSFE-related changes, the frontend request
workflow now stores user-/session-related information
in the middleware.

This is a first step in order to reduce the dependencies
of TSFE + FrontendUserAuthentication.

This patch is breaking as certain hooks (like EOFE)
do not have session data stored anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 912

  1. Benni Mack uploaded patch set 1 06/12/19, 05:14

  2. Benni Mack updated the commit message in patch set 2 06/12/19, 21:05

  3. TYPO3com voted on patch set 2 V +1 06/12/19, 21:28 Completed build in 17m 08s on Wed, 12 Jun, 11:28 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34296

  4. Benni Mack uploaded patch set 3 06/13/19, 08:51

  5. Oliver Hader voted on patch set 3 CR +1 06/13/19, 09:01

  6. Georg Ringer uploaded patch set 4 06/13/19, 09:02

  7. Georg Ringer voted on patch set 4 V +1 CR +1 06/13/19, 09:02

  8. Oliver Hader voted on patch set 4 CR +1 06/13/19, 09:08

  9. TYPO3com voted on patch set 3 V +1 06/13/19, 09:11 Completed build in 18m 49s on Thu, 13 Jun, 11:11 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34310

  10. TYPO3com voted on patch set 4 V +1 06/13/19, 09:20 Completed build in 16m 07s on Thu, 13 Jun, 11:20 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34312

  11. Andreas Kienast voted on patch set 4 V +2 CR +2 06/13/19, 09:29

  12. Andreas Kienast merged patch set 5 06/13/19, 09:29