Review main Merged

60945[BUGFIX] Fix tests on windows

Susi Moog CR +2 V +2 Easy +6 −5 updated 06/17/19, 09:48

Commit message

Some unit tests still have problems on Windows.
- setlocale will not error even if the locale is not found
- file permissions don't work the same as the unix style version
- absolute paths do not start with a slash
- files from finder may contain mixed slashes - generating different hash values when used as key

Tests have either been adjusted to accomodate the differing behaviour or
skipped if appropriate.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1316

  1. Susi Moog uploaded patch set 1 06/12/19, 11:16

  2. Susi Moog updated the commit message in patch set 2 06/13/19, 07:17

  3. Susi Moog commented on patch set 2 06/13/19, 07:18

    This change is ready for review.
  4. Susi Moog rebased onto patch set 3 06/14/19, 08:02

  5. TYPO3com voted on patch set 3 V +1 06/14/19, 08:16 Completed build in 13m 35s on Fri, 14 Jun, 10:16 AM Test Summary: 46514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34341

  6. Benjamin Kott voted on patch set 3 V +1 CR +1 06/17/19, 08:11

  7. Andreas Kienast uploaded patch set 4 06/17/19, 08:17

  8. TYPO3com voted on patch set 4 V +1 06/17/19, 08:27 Completed build in 10m 11s on Mon, 17 Jun, 10:27 AM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34376

  9. Anja Leichsenring commented on patch set 4 CR -1 06/17/19, 08:52

    we miss the fileinfo php extension to successfully execute all tests. This will be done as separate patch.
  10. Anja Leichsenring uploaded patch set 5 06/17/19, 09:01

  11. TYPO3com voted on patch set 5 V +1 06/17/19, 09:11 Completed build in 10m 37s on Mon, 17 Jun, 11:11 AM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34378

  12. Anja Leichsenring commented on patch set 5 V -1 06/17/19, 09:31

    the mimetype test fails if php extension fileinfo is not available.
  13. Anja Leichsenring wrote 06/17/19, 09:48

    Removed Verified-1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  14. Benjamin Kott voted on patch set 5 V +1 CR +1 06/17/19, 09:48

  15. Andreas Kienast commented on patch set 5 V +2 CR +2 06/17/19, 09:48

    Verified by looking at Benji's screen
  16. Andreas Kienast merged patch set 6 06/17/19, 09:48