60945[BUGFIX] Fix tests on windows
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −0
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/SelectViewHelperTest.php+1 −3
- typo3/sysext/install/Tests/Unit/UpgradeAnalysis/DocumentationFileTest.php+2 −2
Review log 1316
-
Susi Moog uploaded patch set 1 06/12/19, 11:16
-
Susi Moog updated the commit message in patch set 2 06/13/19, 07:17
-
Susi Moog commented on patch set 2 06/13/19, 07:18
This change is ready for review. -
Susi Moog rebased onto patch set 3 06/14/19, 08:02
-
TYPO3com voted on patch set 3 V +1 06/14/19, 08:16 Completed build in 13m 35s on Fri, 14 Jun, 10:16 AM Test Summary: 46514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34341
-
Benjamin Kott voted on patch set 3 V +1 CR +1 06/17/19, 08:11
-
Andreas Kienast uploaded patch set 4 06/17/19, 08:17
-
TYPO3com voted on patch set 4 V +1 06/17/19, 08:27 Completed build in 10m 11s on Mon, 17 Jun, 10:27 AM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34376
-
Anja Leichsenring commented on patch set 4 CR -1 06/17/19, 08:52
we miss the fileinfo php extension to successfully execute all tests. This will be done as separate patch. -
Anja Leichsenring uploaded patch set 5 06/17/19, 09:01
-
TYPO3com voted on patch set 5 V +1 06/17/19, 09:11 Completed build in 10m 37s on Mon, 17 Jun, 11:11 AM Test Summary: 46476 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34378
-
Anja Leichsenring commented on patch set 5 V -1 06/17/19, 09:31
the mimetype test fails if php extension fileinfo is not available. -
Anja Leichsenring wrote 06/17/19, 09:48
Removed Verified-1 by Anja Leichsenring <aleichsenring@ab-softlab.de> -
Benjamin Kott voted on patch set 5 V +1 CR +1 06/17/19, 09:48
-
Andreas Kienast commented on patch set 5 V +2 CR +2 06/17/19, 09:48
Verified by looking at Benji's screen -
Andreas Kienast merged patch set 6 06/17/19, 09:48