Review TYPO3_8-7 Merged

60950[BUGFIX] DragUploader: Remove trailing comma in ternary operation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/13/19, 13:13

Commit message

This patch removes a trailing comma in a ternary operation, as this causes
a JavaScript error in Internet Explorer 11.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Frank Nägler +1
    • Riny van Tiggelen +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jonas Eberle +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1011

  1. Andreas Kienast uploaded patch set 1 06/12/19, 13:52

  2. Mathias Brodala commented on patch set 1 CR +1 06/12/19, 13:55

    Sad that we still have to keep this in mind. In 2019 ...
  3. TYPO3com voted on patch set 1 V +1 06/12/19, 14:10 Completed build in 16m 19s on Wed, 12 Jun, 04:10 PM Test Summary: 80310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3543

  4. Riny van Tiggelen voted on patch set 1 CR +1 06/12/19, 14:12

  5. Stephan Großberndt commented on patch set 1 06/12/19, 14:42

    Testing email for comment.
  6. Stephan Großberndt voted on patch set 1 CR -1 06/12/19, 15:49

  7. Stephan Großberndt voted on patch set 1 CR 0 06/12/19, 15:49

  8. Jonas Eberle commented on patch set 1 V +1 CR +1 06/13/19, 13:08

    This fixes the Select & Upload files in IE11. btw: I did not get a DragUploader.js error before - it just did not do anything. Very nice! Thank you!
  9. Frank Nägler voted on patch set 1 V +1 CR +1 06/13/19, 13:13

  10. Andreas Kienast voted on patch set 1 V +2 CR +2 06/13/19, 13:13

  11. Andreas Kienast merged patch set 2 06/13/19, 13:13