Review 9.5 Merged

60952[BUGFIX] Ignore cHash when given but not needed

Benni Mack CR +2 V +2 Normal +123 −4 updated 06/13/19, 08:29

Commit message

If a cHash GET parameter is given, but there
are no GET parameters that are relevant, a
hash_calc() call against an empty string is done.

However, the change now allows an invalid
cHash if no check is necessary. This could
happen when upgrading from older instances
where a cHash is not needed anymore.

Bots would not then fill up the error log
but get the new page (with a valid 200 result)

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack commented on patch set 1 06/12/19, 06:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 06/12/19, 21:48 Completed build in 37m 09s on Wed, 12 Jun, 11:48 PM Test Summary: 4 of 50869 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-776

  3. Benni Mack uploaded patch set 2 06/13/19, 07:52

  4. TYPO3com voted on patch set 2 V +1 06/13/19, 08:09 Completed build in 15m 42s on Thu, 13 Jun, 10:08 AM Test Summary: 50401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-777

  5. Benni Mack voted on patch set 2 V +2 CR +2 06/13/19, 08:29

  6. Benni Mack merged patch set 3 06/13/19, 08:29