Review main Merged

60992[FEATURE] Allow relative paths in Yaml file imports

Benni Mack CR +2 V +2 Normal +167 −24 updated 09/02/19, 06:45

Commit message

Allowing Yaml Files with an import statement that
can be relative to the current file allows to handle cascading
site configuration better.

This way, a common site can actually have global route enhancers
defined in the config/ folder (e.g. config/sites/base.yaml) that
all sites/XYZ/config.yaml files could import by using `../base.yaml`.

This greatly enhances the developer experience for
advanced and larger installations.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2132

Show 47 earlier messages
  1. Benni Mack uploaded patch set 1 06/12/19, 21:04

  2. TYPO3com voted on patch set 1 V -1 06/12/19, 21:22 Completed build in 17m 39s on Wed, 12 Jun, 11:22 PM Test Summary: 40 of 46865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34295

  3. Benni Mack uploaded patch set 2 06/14/19, 15:57

  4. TYPO3com voted on patch set 2 V +1 06/14/19, 16:10 Completed build in 12m 56s on Fri, 14 Jun, 06:10 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34348

  5. Benni Mack updated the commit message in patch set 3 07/13/19, 11:43

  6. TYPO3com voted on patch set 3 V +1 07/13/19, 11:55 Completed build in 12m 03s on Sat, 13 Jul, 01:55 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34987

  7. Benni Mack uploaded patch set 4 07/13/19, 12:00

  1. TYPO3com voted on patch set 4 V +1 07/13/19, 12:12 Completed build in 11m 27s on Sat, 13 Jul, 02:12 PM Test Summary: 47002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34989

  2. Oliver Klee commented on patch set 4 07/13/19, 12:16

    YamlFileLoader.php:44 Unresolved

    Please let's have an @var annotation for this field.

    YamlFileLoader.php:66 Unresolved

    Please let's have a return type declaration.

    YamlFileLoader.php:79 Unresolved

    I propose we refactor this to a method hasFlag(int $flag): bool so that the code is more speaking.
  3. Mathias Brodala commented on patch set 4 07/23/19, 12:19

    Unresolved

    Deluxe? ;-)
  4. Benni Mack uploaded patch set 5 07/24/19, 12:31

  5. TYPO3com voted on patch set 5 V +1 07/24/19, 12:44 Completed build in 12m 46s on Wed, 24 Jul, 02:44 PM Test Summary: 47164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35306

  6. Andreas Kienast uploaded patch set 6 07/26/19, 07:04

  7. TYPO3com voted on patch set 6 V +1 07/26/19, 07:15 Completed build in 11m 22s on Fri, 26 Jul, 09:15 AM Test Summary: 47164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35327

  8. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/02/19, 15:30

  9. Anja Leichsenring voted on patch set 6 V 0 CR 0 08/02/19, 15:31

  10. Anja Leichsenring uploaded patch set 7 08/02/19, 15:36

  11. Anja Leichsenring uploaded patch set 8 08/02/19, 15:39

  12. Anja Leichsenring commented on patch set 8 V +1 CR +1 08/02/19, 15:40

    sorry, I pulled the wrong patchset. Reverted to PS 6.
  13. TYPO3com voted on patch set 7 V +1 08/02/19, 15:49 Completed build in 12m 29s on Fri, 2 Aug, 03:48 PM Test Summary: 47179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35479

  14. TYPO3com voted on patch set 8 V -1 08/02/19, 15:50 Completed build in 10m 47s on Fri, 2 Aug, 03:50 PM Test Summary: 5 of 47538 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35480

  15. TYPO3com voted on patch set 8 V +1 08/02/19, 18:16 Completed build in 2h 47m 44s on Fri, 2 Aug, 06:16 PM Test Summary: 47179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35480

  16. Susi Moog commented on patch set 9 08/02/19, 19:01

    Published edit on patch set 8.
  17. TYPO3com voted on patch set 9 V -1 08/02/19, 19:01 Completed build in 11s on Fri, 2 Aug, 07:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35489

  18. Susi Moog commented on patch set 9 08/02/19, 19:11

    on it.
  19. Susi Moog uploaded patch set 10 08/02/19, 19:45

  20. TYPO3com voted on patch set 10 V +1 08/02/19, 19:56 Completed build in 11m 12s on Fri, 2 Aug, 07:56 PM Test Summary: 47176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35492

  21. Susi Moog voted on patch set 10 CR +1 08/03/19, 09:28

  22. Andreas Kienast voted on patch set 10 CR +1 08/28/19, 14:18

  23. Guido Schmechel voted on patch set 10 V +1 CR +1 08/30/19, 20:48

  24. Richard Haeser voted on patch set 10 V +2 CR +2 09/02/19, 06:45

  25. Richard Haeser merged patch set 11 09/02/19, 06:45