Review main Merged

60993[TASK] Make use of PSR-7 request object in BE Template module

Benni Mack CR +2 V +2 Hard +144 −160 updated 07/05/19, 17:06

Commit message

Switch from GeneralUtility::_GP() to PSR-7 in EXT:tstemplate.

All occurrences are replaced by proper Object-Oriented coding.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1217

  1. Benni Mack uploaded patch set 1 06/12/19, 21:10

  2. TYPO3com voted on patch set 1 V -1 06/12/19, 21:58 Completed build in 47m 10s on Wed, 12 Jun, 11:58 PM Test Summary: 3 of 46865 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34301

  3. Benni Mack uploaded patch set 2 06/18/19, 10:14

  4. TYPO3com voted on patch set 2 V -1 06/18/19, 10:45 Completed build in 25m 10s on Tue, 18 Jun, 12:45 PM Test Summary: 46199 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34418

  5. TYPO3com voted on patch set 2 V +1 06/18/19, 11:01 Completed build in 1h 06m 35s on Tue, 18 Jun, 01:01 PM Test Summary: 46442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34418

  6. Daniel Windloff commented on patch set 2 07/05/19, 12:41

    TypoScriptTemplateModuleController.php:718 Unresolved

    method handleExternalFunctionValue is removed

    TypoScriptTemplateModuleController.php:721 Unresolved

    method handleExternalFunctionValue is removed
  7. Anja Leichsenring commented on patch set 2 07/05/19, 12:55

    TemplateAnalyzerModuleFunctionController.php:78

    the cast should be on the assignment, not the condition, true?

    TypoScriptTemplateConstantEditorModuleFunctionController.php:75 Unresolved

    here, too

    TypoScriptTemplateInformationModuleFunctionController.php:66 Unresolved

    and again
  8. Anja Leichsenring voted on patch set 2 V +1 07/05/19, 12:57

  9. Daniel Windloff voted on patch set 2 V +1 07/05/19, 15:17

  10. Daniel Goerz commented on patch set 2 07/05/19, 16:28

    TemplateAnalyzerModuleFunctionController.php:78 Reply Unresolved

    It is. The whole expression is put in parentheses and the result is cast to an integer.
  11. Andreas Kienast uploaded patch set 3 07/05/19, 16:39

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 07/05/19, 16:39

  13. Daniel Goerz voted on patch set 3 V +1 CR +1 07/05/19, 16:54

  14. TYPO3com voted on patch set 3 V -1 07/05/19, 17:01 Completed build in 17m 29s on Fri, 5 Jul, 07:01 PM Test Summary: 5 of 47065 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34829

  15. TYPO3com voted on patch set 3 V +1 07/05/19, 17:06 Completed build in 39m 33s on Fri, 5 Jul, 07:06 PM Test Summary: 46702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34829

  16. Andreas Kienast voted on patch set 3 V +2 CR +2 07/05/19, 17:06

  17. Andreas Kienast merged patch set 4 07/05/19, 17:06