60997[TASK] Deprecate unused methods of VersionNumberUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php1+9 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88554-DeprecatedMethodsInVersionNumberUtility.rstnew+38 −0
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+0 −67
- typo3/sysext/core/Tests/UnitDeprecated/Utility/VersionNumberUtilityTest.phpnew+93 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php1+21 −0
Review log 1622
-
Georg Ringer uploaded patch set 1 06/13/19, 09:37
-
Georg Ringer commented on patch set 1 06/13/19, 09:38
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 06/13/19, 09:52 Completed build in 15m 00s on Thu, 13 Jun, 11:52 AM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34314
-
Georg Ringer uploaded patch set 2 06/13/19, 09:59
-
TYPO3com voted on patch set 2 V +1 06/13/19, 10:15 Completed build in 16m 49s on Thu, 13 Jun, 12:15 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34316
-
Markus Klein commented on patch set 2 06/13/19, 11:30
Deprecation-88554-DeprecateMethodsInVersionNumberUtility.rst:4UnresolvedDeprecated -
Markus Klein commented on patch set 3 06/13/19, 11:31
Published edit on patch set 2. -
Markus Klein commented on patch set 3 06/13/19, 11:33
convertIntegerToVersionNumber() is also only used in tests -
TYPO3com voted on patch set 3 V -1 06/13/19, 11:40 Completed build in 09m 10s on Thu, 13 Jun, 01:40 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34320
-
Andreas Kienast commented on patch set 3 CR -1 06/13/19, 11:48
MethodCallStaticMatcher.php:889UnresolvedDeprecate*d* -
Andreas Kienast uploaded patch set 4 06/13/19, 11:53
-
TYPO3com voted on patch set 4 V +1 06/13/19, 12:07 Completed build in 13m 21s on Thu, 13 Jun, 02:07 PM Test Summary: 46526 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34321
-
Markus Klein commented on patch set 4 CR -1 06/13/19, 12:12
I would add convertIntegerToVersionNumber() too. (is also only used in tests) -
Oliver Klee commented on patch set 4 06/13/19, 16:31
VersionNumberUtility.php:73UnresolvedCan we also please have @deprecated annotations for the deprecated methods? That way, IDEs can complain when they are used. -
Georg Ringer uploaded patch set 5 06/14/19, 01:57
-
TYPO3com voted on patch set 5 V -1 06/14/19, 01:57 Completed build in 18s on Fri, 14 Jun, 03:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34338
-
Georg Ringer uploaded patch set 6 06/14/19, 02:00
-
TYPO3com voted on patch set 6 V +1 06/14/19, 02:22 Completed build in 18m 05s on Fri, 14 Jun, 04:22 AM Test Summary: 46488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34339
-
Markus Klein voted on patch set 6 V +1 CR +1 06/14/19, 08:36
-
Oliver Klee voted on patch set 6 CR +1 06/14/19, 08:39
-
Benni Mack voted on patch set 6 V +2 CR +2 06/14/19, 19:44
-
Benni Mack merged patch set 7 06/14/19, 19:44